Date: Fri, 2 Nov 2018 09:46:17 +0100 From: Gary Jennejohn <gljennjohn@gmail.com> To: Conrad Meyer <cem@freebsd.org> Cc: Konstantin Belousov <kostikbel@gmail.com>, svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers <src-committers@freebsd.org> Subject: Re: svn commit: r340038 - in head: lib/libc/sys sys/kern Message-ID: <20181102094617.7340e6f2@ernst.home> In-Reply-To: <CAG6CVpU5aLjOB-1N92KpEOFDBpZe4gu5=w6ADWeD=6MgXFPjsQ@mail.gmail.com> References: <201811012346.wA1NkNS5079845@repo.freebsd.org> <20181102004555.GJ5335@kib.kiev.ua> <CAG6CVpU5aLjOB-1N92KpEOFDBpZe4gu5=w6ADWeD=6MgXFPjsQ@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, 1 Nov 2018 20:29:27 -0700 Conrad Meyer <cem@freebsd.org> wrote: > On Thu, Nov 1, 2018 at 5:46 PM Konstantin Belousov <kostikbel@gmail.com> wrote: > > > > On Thu, Nov 01, 2018 at 11:46:23PM +0000, Conrad Meyer wrote: > > > ... > > > @@ -232,7 +232,15 @@ points outside the process's allocated address space. > > > A signal was delivered before the time limit expired and > > > before any of the selected events occurred. > > > .It Bq Er EINVAL > > > -The specified time limit is invalid. One of its components is negative or too large. > > > +The specified time limit is invalid. > > > +One of its components is negative or too large. > > > +.It Bq Er EINVAL > > > +The number of pollfd structures specified by > > > +.Fa nfds > > > +exceeds the system tunable > > > +.Va kern.maxfilesperproc > > > +and > > > +.Dv FD_SETSIZE . > > > > This is somewhat confusing. Looking only at the man page text, most > > straight reading of it is that nfds cannot exceed min(maxfilesperproc, > > FD_SETSIZE). But in fact nfds cannot exceed max of it, which is > > significantly different, i.e. poll(2) does not suffer from the (userspace) > > FD_SETSIZE limitation of select(2). > > min(maxfilesperproc, FD_SETSIZE) would be written as "nfds exceeds ... > maxfilesperproc OR FD_SETSIZE," rather than "and." I think the > sentence is unambiguous. > Based on Konstantin's comment I'd have to say that it is not unambiguous. As a native English speaker I had to read it several times to understand it. I think something like "exceeds both" might be clearer. -- Gary Jennejohn
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20181102094617.7340e6f2>