Date: Thu, 30 Jun 2016 14:03:26 +0200 From: Mathieu Arnold <mat@FreeBSD.org> To: Baptiste Daroussin <bapt@FreeBSD.org> Cc: Bryan Drewery <bdrewery@FreeBSD.org>, ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r417364 - head/Mk/Scripts Message-ID: <ED2C1FF6B1750C421AE8F990@ogg.in.absolight.net> In-Reply-To: <20160630111918.nhilkb4xgrgqwlde@ivaldir.etoilebsd.net> References: <201606231131.u5NBVFur021580@repo.freebsd.org> <075ef3c9-89f1-8e95-c86a-bf00831c373e@FreeBSD.org> <20160630054109.beqlksn3juwodf72@ivaldir.etoilebsd.net> <685BD37565065F0C493733CE@atuin.in.mat.cc> <20160630111918.nhilkb4xgrgqwlde@ivaldir.etoilebsd.net>
next in thread | previous in thread | raw e-mail | index | archive | help
--==========A71BC19C8234FC6D68AC========== Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Content-Disposition: inline +--On 30 juin 2016 13:19:18 +0200 Baptiste Daroussin <bapt@FreeBSD.org> wrote: | On Thu, Jun 30, 2016 at 10:21:03AM +0200, Mathieu Arnold wrote: |> |> |> +--On 30 juin 2016 07:41:09 +0200 Baptiste Daroussin <bapt@FreeBSD.org> |> wrote: |> | On Wed, Jun 29, 2016 at 04:33:52PM -0700, Bryan Drewery wrote: |> |> On 6/23/2016 4:31 AM, Mathieu Arnold wrote: |> |> > Author: mat |> |> > Date: Thu Jun 23 11:31:15 2016 |> |> > New Revision: 417364 |> |> > URL: https://svnweb.freebsd.org/changeset/ports/417364 |> |> > |> |> > Log: |> |> > Extend the symlink checks to warn on absolute targets. |> |> > |> |> > Sponsored by: Absolight |> |> > Differential Revision: https://reviews.freebsd.org/D6930 |> |> |> |> Why? This seems like noise. |> | |> | Quite true as it is I overlooked it. |> | |> | To ease relocatable packages (to prepare sysroot for exemple) symlinks |> | that points to file within the same package should be absolute links. |> | |> | After looking at this patch again I think it should be reverted and |> | replaced later by something that will check symlinks on the same plist |> |> Mmmm, I can add a check to see if the target is in STAGEDIR and only emit |> the warning if it is. | | would definitly help I did that in r417821 (now poudriere doesn't have any symlinks warnings) I added a second warning if the symlink points to something that does't exist anywhere, feel free to remove it if it is annoying too :-) -- Mathieu Arnold --==========A71BC19C8234FC6D68AC========== Content-Type: application/pgp-signature Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQJ8BAEBCgBmBQJXdQqQXxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXQzQUI2OTc4OUQyRUQxMjEwNjQ0MEJBNUIz QTQ1MTZGMzUxODNDRTQ4AAoJEDpFFvNRg85IjbMQAKvU9gEKo4xileq7U6xDxJWR /hWfL4TOSHEaw+geNRFoGUS3b0LFCf+nTnWAu36aYnLB+RlNfXsX266AVEjBpcUR JIT4FlRWATgkcFI6txuxDCSFV4/UiXIMscyB3PdrTZAnlUIAO6C1LsZWFA1FAHg2 k94YlCcUfp85uVIJw+xHMPsU0U1Y2l0OmGEeug2vIzH0SZmw3Yqp2+GDY2n4K6xt adpYXqHxGQC2dtkgziJH4nt0cM3zmQV12YP9oxwMxamxXnJ/4bPOsHL2oPgVJvYe ZHBlJ0hNIRuCUcG+Cq7KN+ox1CR7NWI8uPoovPGLtD5iqNuc2yfh3Zzs5KTywZyi yi7Zglzv8rDloPpxOhlxVOlz0+kWww+znu821Nz9ILpMMXsMTe6l5Yd6AuNo8ma2 qszE04KCX7Yg1zg1m7LQFwOwXOpPxVk/3tNHipNceVj5w2TA0/vrz7DerZZxHoJK uxdmyOJJwzNaYsOeNNR3tcFZd8r2KjOV+ZUg2WpeVWQl2CWQNDAcdHm1Zt1F2phf OVmEgVWLgoW2pVLwG7nLYbZVc7TcWGhwGj82svewcmm0vKLH2K3b6BJ02nFBD9wZ 0OtN4o1SMVZCYeMvLBzW011rWp0gowVyLMImaYHOLib4VUKUBjn2nJlNgB6Rq8RM 8pZWENDfMtkdPR5XTC9L =SCVw -----END PGP SIGNATURE----- --==========A71BC19C8234FC6D68AC==========--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?ED2C1FF6B1750C421AE8F990>