Date: Fri, 10 Mar 2006 06:40:02 GMT From: Warner Losh <imp@FreeBSD.org> To: Perforce Change Reviews <perforce@freebsd.org> Subject: PERFORCE change 93095 for review Message-ID: <200603100640.k2A6e2fM072334@repoman.freebsd.org>
next in thread | raw e-mail | index | archive | help
http://perforce.freebsd.org/chv.cgi?CH=93095 Change 93095 by imp@imp_hammer on 2006/03/10 06:39:29 Try to use m_devget() as suggested by jhb and done in the de driver. Affected files ... .. //depot/projects/arm/src/sys/arm/at91/if_ate.c#38 edit Differences ... ==== //depot/projects/arm/src/sys/arm/at91/if_ate.c#38 (text+ko) ==== @@ -24,10 +24,8 @@ /* TODO: (in no order) * - * 5) Setup RX buffers in ateinit_locked * 8) Need to sync busdma goo in atestop * 9) atestop should maybe free the mbufs? - * 10) On Rx, how do we get a new mbuf? * * 1) detach * 2) Free dma setup @@ -657,7 +655,8 @@ mb->m_len = rx_stat & ETH_LEN_MASK; mb->m_pkthdr.len = mb->m_len; mb->m_pkthdr.rcvif = sc->ifp; - tmp_mbuf = m_copyup(mb, ETHER_HDR_LEN, 2); + tmp_mbuf = m_devget(mtod(md, caddr_t), mb->m_len, + ETHER_ALIGN, sc->ifp, NULL); /* * For the last buffer, set the wrap bit so * the controller restarts from the first @@ -671,7 +670,8 @@ BUS_DMASYNC_PREREAD); bus_dmamap_sync(sc->rx_desc_tag, sc->rx_desc_map, BUS_DMASYNC_PREWRITE); - (*sc->ifp->if_input)(sc->ifp, tmp_mbuf); + if (tmp_mbuf != NULL) + (*sc->ifp->if_input)(sc->ifp, tmp_mbuf); } } if (status & ETH_ISR_TCOM) {
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200603100640.k2A6e2fM072334>