Date: Thu, 10 Jun 2010 12:20:17 -0700 From: Juli Mallett <jmallett@FreeBSD.org> To: Alexander Sack <pisymbol@gmail.com> Cc: freebsd-net@freebsd.org, Jack Vogel <jfvogel@gmail.com> Subject: Re: Dual-rate transceivers with ixgbe? Message-ID: <AANLkTilqb4y0zEmom0jyg-HEi4yp8D3nkkbUWGHUjWPt@mail.gmail.com> In-Reply-To: <AANLkTikjs42mE5QHnSvZ9x9DI1xfYowvIES-DRORz6hH@mail.gmail.com> References: <AANLkTinO9NZ8F9TeS68I2ULQgdlMGzlXkinCsywWosAM@mail.gmail.com> <AANLkTinS607kd3wc3F2WWmA6Zk9KL4GhscxEHPtcvxA5@mail.gmail.com> <AANLkTimkxOn9h6SAkTPDqfUM9kl2CZiFrZC_BuNDfRyB@mail.gmail.com> <AANLkTikcQMXk8UebmaynOeeInGiwx8yr0NMGE1yJfm8u@mail.gmail.com> <AANLkTil_YRvU54qHtIMO7mP4yYjojeHVrCHaRcl2K2Ug@mail.gmail.com> <AANLkTim5Ao9nSh6T6HF7NztLgvbTzxuVyr8lSXAJ7bMo@mail.gmail.com> <AANLkTim9-Za5mzLTw7MDAHY_TuIQsQ0SF0_1xpxyGY7v@mail.gmail.com> <AANLkTik-V2frmirwBLtg4RemdEVvPhUmVsOP7CqEkvUi@mail.gmail.com> <AANLkTikqjQic_M3mX7OTx-V0OJxbk4vzxajPmHmIUAKa@mail.gmail.com> <AANLkTikjs42mE5QHnSvZ9x9DI1xfYowvIES-DRORz6hH@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, Jun 10, 2010 at 12:04, Alexander Sack <pisymbol@gmail.com> wrote: > However, would it be possible to please make this a kenv tunable in > the driver? =A0Its kinda stupid I have to recompile to add a SFP. =A0It > can certainly be an unsupported feature by you. This is a good idea, but asking Jack to commit something that goes against Intel's wishes and which he's not going to support is probably a losing strategy. Whether he minds someone else committing might be another story :) One thing that the base driver probably ought to do is not fail in attach if there's an unrecognized SFP+ module. Since we get interrupts on module change (although this doesn't seem to always work *entirely* right in the stock sources, mostly wrt stored values of AUTOC and the like) it should be possible to bring the interface up with the unsupported (and disabled) SFP+ module and do the SFP+ module probing we already do on hot-swap. > Patch attached. =A0Tested with CURRENT driver on a 7.2-amd64-release > machine. =A0If you set the tunable to 1, ixgbe loads without issue. =A0If > you leave it to zero (default), it will not attach to unsupported > SFPs. If you're going to do this, you ought to support SFP as well as SFP+ modules which requires a few more changes. But not very many :) Although some SFP modules seem to return something for the comp_codes_10g read, which makes deciding which SFI mode to configure non-trivial, short of providing an actual vendor/model switch. Thanks, Juli.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?AANLkTilqb4y0zEmom0jyg-HEi4yp8D3nkkbUWGHUjWPt>