Date: Thu, 7 Dec 2017 08:13:08 +0000 From: Pietro Cerutti <gahr@FreeBSD.org> To: Joe Marcus Clarke <marcus@FreeBSD.org> Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r447981 - in head/ports-mgmt/portlint: . src Message-ID: <20171207081308.5bxt5mp2o5wr33un@ptrcrt.ch> In-Reply-To: <20171207081055.xtssqrp5okethfeu@ptrcrt.ch> References: <201708151243.v7FChEAF043279@repo.freebsd.org> <20171207080421.qijzbigqkbfbezqe@ptrcrt.ch> <20171207081055.xtssqrp5okethfeu@ptrcrt.ch>
next in thread | previous in thread | raw e-mail | index | archive | help
--nalnlcqgljz4v63y Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Dec 7 17 08:10, Pietro Cerutti wrote: > On Dec 7 17 08:04, Pietro Cerutti wrote: > > On Aug 15 17 12:43, Joe Marcus Clarke wrote: > > > Author: marcus > > > Date: Tue Aug 15 12:43:14 2017 > > > New Revision: 447981 > > > URL: https://svnweb.freebsd.org/changeset/ports/447981 > > >=20 > > > Log: > > > Update to 2.17.12. > >=20 > > > @@ -3400,6 +3437,11 @@ sub abspathname { > > > =20 > > > if ($pre =3D~ /MASTER_SITE_SUBDIR/) { > > > # MASTER_SITE_SUBDIR lines are ok. > > > + $i =3D ''; > > > + } > > > + if ($s =3D~ /\$\{[^}]*?$i/) { > > > + # If we're inside a make variable, we probably do not have > > > + # an absolute path. > > > $i =3D ''; > > > } > > > } > > >=20 > >=20 > > Unmatched ) in regex; marked by <-- HERE in m/\$\{[^}]*?/dev/null 2>&1 = )=20 > > <-- HERE / at /usr/local/bin/portlint line 3443. > >=20 > > I think the ? doesn't belong there. >=20 > No, my analysis was wrong. It's about the contents of the $i variable.=20 > Here's why. You can reproduce by portlint -AC in net-im/openfire. >=20 > i is /var/log/openfire > WARN: Makefile: possible use of absolute pathname "/var/log/openfire". >=20 > i is /var/db/openfire > WARN: Makefile: possible use of absolute pathname "/var/db/openfire". >=20 > i is /dev/null 2>&1 ) > Unmatched ) in regex; marked by <-- HERE in m/\$\{[^}]*?/dev/null 2>&1 )= =20 > <-- HERE / at /usr/local/bin/portlint line 3444. Surrounding $i with \Q and \E in the regex solves the problem. --=20 Pietro Cerutti The FreeBSD Project gahr@FreeBSD.org --nalnlcqgljz4v63y Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQJiBAABCgBMFiEE2m3hBqW4VLhd2G1JrdDTjqGSCJ4FAloo+BQuFIAAAAAAFQAQ cGthLWFkZHJlc3NAZ251cGcub3JnZ2FockBGcmVlQlNELm9yZwAKCRCt0NOOoZII ntZiEACzoIgRse8q49YxZwBdFaCAVm0WRjNtru2eVB9R49/gOlP3v+8rS85FsBM6 IzR6iJdya0QC0DOh5TFH9CyBKzuCWjbiGlRz238cO1oiS9Zf4nY67NWCMRGjlV43 Q1CUTX92MOi3I4Px1j2QIv36RJeOWKiAiExnpODTmxJAX8GBPqNJAMA9wvM0itnZ oF7pBe2XTHB67GS7Vteas0hx9MT9H2csZyz/37Mn2x2fPUBar7DMW58mc/QJ6sxb wk4p8LoeFWFQMbm9WlV+HZba71TW7Cakwy9pXjziHdB+vdY9DDwZ893bMw0Zf8TC lspCcRib0VYcxUchurnKD6VCs4Pe94VTjp5Y4M7tbUFPrjg6G5ypJ2UKa86wvMHp 6MuI0sVJif3aCrJwCquDv6d620JXhSO+5tzpcIg4Q7vA0hmOUInsBvKbI2pt20A6 H87a5mrgBluzGlISJVgmGE30a1DY0Vmwfh4Ca9npYQ9urePhmH4yI/JtwKHLz0A7 2L9rMpK90FEHMoDDJGOGV6KW9Glnw8OVzsNuVnd0i8bJbzq0FP6zTG1pctkgtOIx /tZnvOEJgVaIPI1Nt6WoHYGe1Vx856cZ9Uh7ihLIZLq3Og1ChzJNWtLZWWRS7++J CYFwwokuHh0exP2il/kXH9G+6k2lA3ndxuS4av9z+dd7D2/L+w== =gvui -----END PGP SIGNATURE----- --nalnlcqgljz4v63y--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20171207081308.5bxt5mp2o5wr33un>