Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 24 Nov 2009 16:53:35 +0200
From:      Mikolaj Golub <to.my.trociny@gmail.com>
To:        FreeBSD Stable <freebsd-stable@freebsd.org>
Subject:   pthread.h: typo in #define pthread_cleanup_push/pthread_cleanup_pop
Message-ID:  <86aayc7z4g.fsf@zhuzha.ua1>

next in thread | raw e-mail | index | archive | help
Hi,

I have problems with compiling our application under 8.0.

It fails due to these definitions in pthread.h that look like a typo or
incorrectly applied patch:

    170 #define         pthread_cleanup_push(cleanup_routine, cleanup_arg)              \
    171                 {                                                               \
    172                         struct _pthread_cleanup_info __cleanup_info__;          \
    173                         __pthread_cleanup_push_imp(cleanup_routine, cleanup_arg,\
    174                                 &__cleanup_info__);                             \
    175                         {
    176 
    177 #define         pthread_cleanup_pop(execute)                                    \
    178                         }                                                       \
    179                         __pthread_cleanup_pop_imp(execute);                     \
    180                 }


This patch fixes the problem for me:

--- pthread.h.orig    2009-11-24 16:44:13.000000000 +0200
+++ pthread.h   2009-11-24 16:44:45.000000000 +0200
@@ -172,10 +172,10 @@
                        struct _pthread_cleanup_info __cleanup_info__;          \
                        __pthread_cleanup_push_imp(cleanup_routine, cleanup_arg,\
                                &__cleanup_info__);                             \
-                       {
+               }       
 
 #define                pthread_cleanup_pop(execute)                                    \
-                       }                                                       \
+               {                                                       \
                        __pthread_cleanup_pop_imp(execute);                     \
                }

-- 
Mikolaj Golub



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?86aayc7z4g.fsf>