Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 9 Jan 2009 20:38:21 +0000 (UTC)
From:      Alexander Motin <mav@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-stable@freebsd.org, svn-src-stable-7@freebsd.org
Subject:   svn commit: r186969 - in stable/7/sys: . contrib/pf dev/ath/ath_hal dev/cxgb netgraph
Message-ID:  <200901092038.n09KcLDf067835@svn.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: mav
Date: Fri Jan  9 20:38:21 2009
New Revision: 186969
URL: http://svn.freebsd.org/changeset/base/186969

Log:
  MFC rev. 185179
  
  Remove unneeded NULL check. At first msg can't be null here and and at second
  NG_FREE_MSG() also checks it.
  
  Found with:	Coverity Prevent(tm)

Modified:
  stable/7/sys/   (props changed)
  stable/7/sys/contrib/pf/   (props changed)
  stable/7/sys/dev/ath/ath_hal/   (props changed)
  stable/7/sys/dev/cxgb/   (props changed)
  stable/7/sys/netgraph/ng_base.c

Modified: stable/7/sys/netgraph/ng_base.c
==============================================================================
--- stable/7/sys/netgraph/ng_base.c	Fri Jan  9 20:34:32 2009	(r186968)
+++ stable/7/sys/netgraph/ng_base.c	Fri Jan  9 20:38:21 2009	(r186969)
@@ -2847,8 +2847,7 @@ ng_generic_msg(node_p here, item_p item,
 	 */
 out:
 	NG_RESPOND_MSG(error, here, item, resp);
-	if (msg)
-		NG_FREE_MSG(msg);
+	NG_FREE_MSG(msg);
 	return (error);
 }
 



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200901092038.n09KcLDf067835>