Date: Mon, 31 May 2010 01:11:06 GMT From: Garrett Cooper <gcooper@FreeBSD.org> To: Perforce Change Reviews <perforce@FreeBSD.org> Subject: PERFORCE change 178991 for review Message-ID: <201005310111.o4V1B63P052609@repoman.freebsd.org>
next in thread | raw e-mail | index | archive | help
http://p4web.freebsd.org/@@178991?ac=10 Change 178991 by gcooper@gcooper-bayonetta on 2010/05/31 01:10:16 Add warnings about QA issues with plist_add* Affected files ... .. //depot/projects/soc2007/gcooper-pkg_install-enhancements-simplified/lib/libpkg/plist.c#9 edit Differences ... ==== //depot/projects/soc2007/gcooper-pkg_install-enhancements-simplified/lib/libpkg/plist.c#9 (text+ko) ==== @@ -34,7 +34,12 @@ #include "pkg.h" -/* Add an item to a packing list */ +/* + * Add an item to a packing list + * + * FIXME: this will `silently fail' until the next point when p is + * dereferenced. + */ void add_plist(Package *p, plist_t type, const char *arg) { @@ -71,6 +76,10 @@ } +/* + * FIXME: this will `silently fail' until the next point when p is + * dereferenced. + */ void add_plist_top(Package *p, plist_t type, const char *arg) {
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201005310111.o4V1B63P052609>