Date: Tue, 31 Dec 2013 18:22:01 +0800 From: Gerald Pfeifer <gerald@pfeifer.com> To: Antoine Brodin <antoine@FreeBSD.org>, ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r337464 - in head: audio/alure audio/fpc-openal audio/freealut audio/hs-ALUT audio/hs-OpenAL audio/py-al audio/py-openal deskutils/xneur devel/allegro-devel devel/love devel/love07 deve... Message-ID: <9085f71d-db56-4f8d-9911-461c7a87d47c@email.android.com> In-Reply-To: <201312252329.rBPNTY87062947@svn.freebsd.org> References: <201312252329.rBPNTY87062947@svn.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Antoine Brodin <antoine@FreeBSD.org> wrote:
>Log:
> Convert the tree to USES=openal
>
> Approved by: portmgr (bapt)
>Modified: head/emulators/wine-devel/Makefile
>==============================================================================
>--- head/emulators/wine-devel/Makefile Wed Dec 25 23:24:54
>2013 (r337463)
>+++ head/emulators/wine-devel/Makefile Wed Dec 25 23:29:34
>2013 (r337464)
>@@ -53,6 +53,9 @@ WINEMAKER_DESC= Fully support winemaker
> GECKO_DESC= Bundle Gecko MSI package for Wine
> MONO_DESC= Bundle Mono MSI package for Wine
>
>+# USES needs to be before bsd.port.pre.mk
>+OPENAL_USES= openal
>+
> PORTDATA= l_intl.nls wine.inf
>
> .include <bsd.port.pre.mk>
>@@ -98,7 +101,6 @@ CONFIGURE_ARGS+= --without-xslt
>
> .if ${PORT_OPTIONS:MOPENAL}
> CONFIGURE_ARGS+= --with-openal
>-USE_OPENAL= yes
> .else
> CONFIGURE_ARGS+= --without-openal
> .endif
>
>Modified: head/emulators/wine/Makefile
>==============================================================================
>--- head/emulators/wine/Makefile Wed Dec 25 23:24:54 2013 (r337463)
>+++ head/emulators/wine/Makefile Wed Dec 25 23:29:34 2013 (r337464)
>@@ -58,6 +58,9 @@ WINEMAKER_DESC= Fully support winemaker
> GECKO_DESC= Bundle Gecko MSI package for Wine
> MONO_DESC= Bundle Mono MSI package for Wine
>
>+# USES needs to be before bsd.port.pre.mk
>+OPENAL_USES= openal
>+
> PORTDATA= fonts/ generic.ppd l_intl.nls wine.inf
>
> PORTSCOUT= limitw:1,even
>@@ -105,7 +108,6 @@ CONFIGURE_ARGS+= --without-xslt
>
> .if ${PORT_OPTIONS:MOPENAL}
> CONFIGURE_ARGS+= --with-openal
>-USE_OPENAL= yes
> PLIST_SUB+= OPENAL=""
> .else
> CONFIGURE_ARGS+= --without-openal
Per my earlier mail I am pretty hampered accessing FreeBSD code right now, but...is this really right?
Pulling in OpenAL unconditionally for these two ports looks strange to me; definitely not intuitive.
Gerald
--
Gerald Pfeifer <gerald@pfeifer.com>
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?9085f71d-db56-4f8d-9911-461c7a87d47c>