Skip site navigation (1)Skip section navigation (2)
Date:      Sun, 1 Sep 2013 12:58:09 +0000
From:      Alexey Dokuchaev <danfe@FreeBSD.org>
To:        Armin Pirkovitsch <sperber@FreeBSD.org>
Cc:        svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org
Subject:   Re: svn commit: r325851 - in head/multimedia/miro: . files
Message-ID:  <20130901125809.GA57685@FreeBSD.org>
In-Reply-To: <201309011237.r81Cbucl085994@svn.freebsd.org>
References:  <201309011237.r81Cbucl085994@svn.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Sun, Sep 01, 2013 at 12:37:56PM +0000, Armin Pirkovitsch wrote:
> New Revision: 325851
> URL: http://svnweb.freebsd.org/changeset/ports/325851
> 
> Log:
>   - Update multimedia/miro to 6.0
>   - change ffmpeg dependency to ffmpeg1
>   - update maintainer to swills@ (suggested and accepted over irc)
>   
>   PR:           ports/181348
>   Submitted by: Steve Wills <swills _AT_ FreeBSD.org>

Any reason not to use Steve's freefall login in Submitted by: tag? :)

> -MAINTAINER=	sperber@FreeBSD.org
> +MAINTAINER=	swills@FreeBSD.org
>  COMMENT=	A video player to get internet TV broadcasts

You could've dropped leading indefinite article while you're on it.

> +LIB_DEPENDS=	avutil1:${PORTSDIR}/multimedia/ffmpeg1 \
> +		sqlite3:${PORTSDIR}/databases/sqlite3

Also, you could have adopted new LIB_DEPENDS syntax (per r322328).  And
last but not least, you (or Steve) might want to consider switching to
dynamic PLIST, as it's just huge right now.

./danfe



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20130901125809.GA57685>