Date: Wed, 23 Aug 2017 17:59:30 +0200 From: Baptiste Daroussin <bapt@FreeBSD.org> To: Romain =?iso-8859-1?Q?Tarti=E8re?= <romain@FreeBSD.org> Cc: Mathieu Arnold <mat@FreeBSD.org>, ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r448620 - in head: devel/leatherman/files devel/llvm-devel/files sysutils/facter/files x11-wm/cde/files Message-ID: <20170823155930.2fbwn4em5eo2wghh@ivaldir.net> In-Reply-To: <20170823154922.GA47318@blogreen.org> References: <201708231403.v7NE38mL020611@repo.freebsd.org> <20170823144023.GD13824@blogreen.org> <92421b70-4930-f0f0-3d04-c225c00ab7e9@FreeBSD.org> <20170823145830.GE13824@blogreen.org> <3180d43a-c87d-54cb-7a6a-61ff05669c58@FreeBSD.org> <20170823154922.GA47318@blogreen.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--t57kxyr5sr5o56bk Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Aug 23, 2017 at 05:49:22PM +0200, Romain Tarti=C3=A8re wrote: > On Wed, Aug 23, 2017 at 05:32:53PM +0200, Mathieu Arnold wrote: > > I do not really understand what this patch is trying to achieve > >=20 > > Baptiste and I only talked about patches, there are no patches in it. >=20 > Okay, I might be missing something basic=E2=80=A6 >=20 > $FreeBSD$ may be expanded to something that gives information about the > svn revision the file was last modified. For this to happen, the > 'svn:keywords' property should be set to something like 'FreeBSD=3D%H'. >=20 > At some point, it was decided that this information was useless for > patches and such lines where removed from them. I don't really see > value here for the removal, but I agree that those keywords did not > really bring value neither, so this looks OK to me. >=20 > We have many files with "$FreeBSD$" in them and without svn:keywords > set. There is therefore no keyword expansion in them, and I don't see > more value added by these "$FreeBSD$" strings in these files than in > patches=E2=80=A6 Hence the proposed patch to remove them. >=20 >=20 > If these non-expanded keyword make sense for non-patches and do not make > sense for patches, please explain this to me why, because I really don't > understand the difference :-S. >=20 > Thanks! In my opinion those keywords are nowaday useless anywhere, but that is anot= her subject :) Best regards, Bapt --t57kxyr5sr5o56bk Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEgOTj3suS2urGXVU3Y4mL3PG3PloFAlmdpl8ACgkQY4mL3PG3 PlrnpA/+KAprM17JwvnF9hZkR4PjQQ5SzHydMcDKpfB68TIw94qOnJ786/hc8nXS KpGMmhVL5UvfBvn3Epv1gr3rP88LcQAC6KMeENgezX+w6EN1wcU+nyMCmPvEAjhK NU7XWQUe+g+lRDfIZHSzFfiZs+qoPH8BTjVx4jQARfF4O456UCWemyifA/HQUGw4 nErkZYd//V0YzDIfb78at9eltk5vJrdXIOng1YcWIT4hmyJuJHvw4AF338+YF5fy wkdnK9n+J/7Cmwa2TQ54r1MDq5eUbjRzfztXfwDLdRRKrpHxlX2fwlf/e0fMp8Vi mluTn0U6mRMD/0TSDoMjkxcRIDJbV5Yh+9cg9vAOpDnRbjB++abvzfKHEVV2VJ98 XVAFFJA+o0YEForPEAjoLi8j25eeAxD9Rs2tnNir5unUog86xLoD9a+8Hv+H/j41 97lkpEH03DYy5+/AuZuZqgLh7BZIeBvARjysSEZDXAN6aArekEst2WJsHHikUCWn 3OZhcNwF/PAbf9pRcm3uU2qTzRVYP5Gvh3mboE43EzKi5yvaulb7RLLWSMSMa9RL zk+T+r0VQO4rBQhn/1RL/0F0mK5ncx6H6FdFe3NoKBTBM/OF6TNGGWziXYyJuOMW sTdUhUugbs1R0AiYR/bK0LVLZiDOsDJUi4gq11Jy6kGm4Okgy+w= =dAOP -----END PGP SIGNATURE----- --t57kxyr5sr5o56bk--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20170823155930.2fbwn4em5eo2wghh>