Date: Fri, 24 May 2019 15:29:41 -0500 From: Justin Hibbits <chmeeedalf@gmail.com> To: Alexey Dokuchaev <danfe@freebsd.org> Cc: Piotr Kubaj <pkubaj@freebsd.org>, svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r348250 - head/sys/powerpc/conf Message-ID: <20190524152941.40f7e239@titan.knownspace> In-Reply-To: <20190524202252.GA72774@FreeBSD.org> References: <201905242001.x4OK1xA6091025@repo.freebsd.org> <20190524151651.7e6b7f09@titan.knownspace> <20190524202252.GA72774@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, 24 May 2019 20:22:52 +0000 Alexey Dokuchaev <danfe@freebsd.org> wrote: > On Fri, May 24, 2019 at 03:16:51PM -0500, Justin Hibbits wrote: > > On Fri, 24 May 2019 20:01:59 +0000 (UTC) Piotr Kubaj wrote: > > > New Revision: 348250 > > > URL: https://svnweb.freebsd.org/changeset/base/348250 > > > > > > Log: > > > Add snd_hda(4) to GENERIC64 used by powerpc64. > > > > > > amd64 also has snd_hda(4) in GENERIC. > > > > > > Modified: > > > head/sys/powerpc/conf/GENERIC64 > > > ... > > > > To note: This was done because there's a strange bug in the snd_hda > > module, with the hdaa component. For some reason it either doesn't > > find all the internal components it needs, or something, because > > there's a NULL dereference when trying to call a kobj method in > > hdaa_attach(). > > So this commit essentially masks the real bug somewhere rather than > fixing it, is this what you're saying? > > ./danfe It's a viable workaround to a problem that reaches a wide audience. Since it works built-in, I found it acceptable. I probably should have filed a bug for it a year ago when I hit it and worked around it, but it could also very well be a compiler issue. By the way, it works fine on powerpc (32-bit) loaded as a module. - Justin
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20190524152941.40f7e239>