Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 22 Apr 2004 02:43:23 -0400
From:      Brian Fundakowski Feldman <green@FreeBSD.org>
To:        Darren Reed <darrenr@hub.freebsd.org>
Cc:        Max Laier <max@love2party.net>
Subject:   Re: cvs commit: src/sys/net radix.c 
Message-ID:  <200404220643.i3M6hNph001564@green.homeunix.org>
In-Reply-To: Message from Darren Reed <darrenr@hub.freebsd.org>  <20040422051953.GA27025@hub.freebsd.org> 

next in thread | previous in thread | raw e-mail | index | archive | help
Darren Reed <darrenr@hub.freebsd.org> wrote:
> On Thu, Apr 22, 2004 at 02:59:38AM +0000, Max Laier wrote:
> > > In the end, if someone decides that the code needs to be restructured
> > > for better performance in SMP hardware, then that's what'll happen and
> > > changes like these will have little significance at that point in time.
> > 
> > I don't think so. It's much easier to restructure code you can actually read 
> > and understand. And honest, when one sees the current radix code (etc.), the 
> > first thing that comes to mind is "run!". Same applies to IPv6/KAME-code, btw 
> > - and I didn't see anybody to work on the locking there and I know a reason 
> > why.
> 
> Now now, don't be mean :)
> 
> But don't forget that at least the way the radix code "was" had the
> backing of a number of chapters in a book that explain(ed/s) it all
> and so it has an advantage over IPv6/KAME...

We're not Unix; we're FreeBSD+KAME+abazillionotherthings, and whatever 
advantages Stevens' historical Unix had in the way of book documentation, 
you can count on it being out of date when it comes to what the code 
actually looks like, whether Luigi is "cleaning it up" or not.

-- 
Brian Fundakowski Feldman                           \'[ FreeBSD ]''''''''''\
  <> green@FreeBSD.org                               \  The Power to Serve! \
 Opinions expressed are my own.                       \,,,,,,,,,,,,,,,,,,,,,,\




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200404220643.i3M6hNph001564>