Date: Thu, 14 Jan 2016 17:17:23 -0500 From: Pedro Giffuni <pfg@FreeBSD.org> To: Warner Losh <imp@bsdimp.com> Cc: Steven Hartland <steven@multiplay.co.uk>, Nathan Whitehorn <nwhitehorn@freebsd.org>, src-committers <src-committers@freebsd.org>, "svn-src-all@freebsd.org" <svn-src-all@freebsd.org>, "svn-src-head@freebsd.org" <svn-src-head@freebsd.org> Subject: Re: svn commit: r294029 - in head/sys/boot/efi: . boot1 loader Message-ID: <56981E73.1020101@FreeBSD.org> In-Reply-To: <CANCZdfrOPJxSDNYbK_n8f6XSZ5b8qGb3DgT65pyiNnM8LLfVFw@mail.gmail.com> References: <201601141853.u0EIrshB007863@repo.freebsd.org> <56980BAE.6070304@freebsd.org> <569812A6.9020101@freebsd.org> <5698172E.6040107@FreeBSD.org> <CANCZdfrOPJxSDNYbK_n8f6XSZ5b8qGb3DgT65pyiNnM8LLfVFw@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On 01/14/16 16:53, Warner Losh wrote: > > On Thu, Jan 14, 2016 at 2:46 PM, Pedro Giffuni <pfg@freebsd.org > <mailto:pfg@freebsd.org>> wrote: > > > > El 14/01/2016 a las 16:27, Steven Hartland escribió: > > > > On 14/01/2016 20:57, Nathan Whitehorn wrote: > > > > On 01/14/16 10:53, Steven Hartland wrote: > > Author: smh > Date: Thu Jan 14 18:53:54 2016 > New Revision: 294029 > URL: https://svnweb.freebsd.org/changeset/base/294029 > > Log: > Only build EFI components on supported compilers > As the in-tree GCC does not support > __attribute__((ms_abi)) EFI can only > be built with Clang. > The EFI loader and boot1 validated this, but > unused libefi was still built > causing issues under GCC after warnings where > enabled by r293724. > Disable building all of EFI when the selected > compiler is GCC. > > > How about with newer-than-4.2 versions of GCC? Surely this > *is* supported in newer compilers. Do we need some build > infrastructure to how about the compiler version as well as > type? > -Nathan > > > If it is then even without this change you wouldn't have have > got the EFI loader or boot1, just an unused libefi. > > This change ensures that builds with in-tree Clang and GCC build > on all platforms, even if GCC doesn't build the EFI components. > > If someone that uses none in-tree GCC has some time to dedicate > to make this work that would be great :) > > > Specially since the gcc-4.2 compiler will be axed mercilessly before > 11.0-RELEASE. > > > We hope, you mean. > As scheduled ... I mean. It was discussed in the BSDCan 2014 Dev Summit. > Never versions of gcc will be supported where they work, and will be > required for some platforms where clang isn't quite there. When we unhook the old crappy GCC someone will be forced to figure out how to get the external toolchain working. Otherwise we can sit and wait for ever. Pedro.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?56981E73.1020101>