Date: Thu, 26 Nov 2020 14:47:53 -0800 From: Cy Schubert <Cy.Schubert@cschubert.com> To: Stefan Esser <se@freebsd.org> Cc: Cy Schubert <Cy.Schubert@cschubert.com>, "O. Hartmann" <ohartmann@walstatt.org>, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r368072 - in head/contrib/bc: . gen include manuals manuals/bc manuals/dc src src/bc src/dc src/history src/rand tests Message-ID: <202011262247.0AQMlrE5071306@slippy.cwsent.com> In-Reply-To: <aee14858-17ac-54c2-97e1-91938bee819a@freebsd.org> References: <202011261739.0AQHdpe5012982@repo.freebsd.org> <20201126191949.092c9eba@thor.intern.walstatt.dynvpn.de> <95c3e226-6050-2f91-debf-317d6d11494f@freebsd.org> <202011262003.0AQK3BTe076596@slippy.cwsent.com> <aee14858-17ac-54c2-97e1-91938bee819a@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
In message <aee14858-17ac-54c2-97e1-91938bee819a@freebsd.org>, Stefan Esser
wri
tes:
> This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
> --maOtBJEdTLpVHYJ8ME4Ow5t7gyU1h0CIy
> Content-Type: multipart/mixed; boundary="m8M7hYutSXzrBuT8orVd2JNQQPKxzBZwZ";
> protected-headers="v1"
> From: Stefan Esser <se@freebsd.org>
> To: Cy Schubert <Cy.Schubert@cschubert.com>
> Cc: "O. Hartmann" <ohartmann@walstatt.org>, src-committers@freebsd.org,
> svn-src-all@freebsd.org, svn-src-head@freebsd.org
> Message-ID: <aee14858-17ac-54c2-97e1-91938bee819a@freebsd.org>
> Subject: Re: svn commit: r368072 - in head/contrib/bc: . gen include manuals
> manuals/bc manuals/dc src src/bc src/dc src/history src/rand tests
> References: <202011261739.0AQHdpe5012982@repo.freebsd.org>
> <20201126191949.092c9eba@thor.intern.walstatt.dynvpn.de>
> <95c3e226-6050-2f91-debf-317d6d11494f@freebsd.org>
> <202011262003.0AQK3BTe076596@slippy.cwsent.com>
> In-Reply-To: <202011262003.0AQK3BTe076596@slippy.cwsent.com>
>
> --m8M7hYutSXzrBuT8orVd2JNQQPKxzBZwZ
> Content-Type: text/plain; charset=windows-1252; format=flowed
> Content-Language: en-US
> Content-Transfer-Encoding: quoted-printable
>
> Am 26.11.20 um 21:03 schrieb Cy Schubert:> But this is still a problem:
> >=20
> > ld: error: undefined symbol: bc_lib_name
> >>>> referenced by vm.c:752 (/opt/src/svn-current/contrib/bc/src/vm.c:752=
> )
> >>>> lto.tmp:(bc_vm_boot)
> >=20
> > ld: error: undefined symbol: bc_lib
> >>>> referenced by lex.c:225 (/opt/src/svn-current/contrib/bc/src/lex.c:2=
> 25)
> >>>> lto.tmp:(bc_vm_boot)
> >>>> referenced by lex.c:227 (/opt/src/svn-current/contrib/bc/src/lex.c:2=
> 27)
> >>>> lto.tmp:(bc_vm_boot)
> > cc: error: linker command failed with exit code 1 (use -v to see invoca=
> tion)
> > *** [gh-bc.full] Error code 1
>
> I cannot reproduce this issue on my system.
>
> The symbols are defined in files generated by gen/strgen.sh and
> there was a change in the parameters passed to this script, but
> I had fixed usr.bin/gh-bc/Makefile accordingly (first in the port
> and then in base).
>
> The generated file lib.c should start like this:
> -----------------------------------------------------------------
> // Copyright (c) 2018-2020 Gavin D. Howard and contributors.
> // Licensed under the 2-clause BSD license.
> // *** AUTOMATICALLY GENERATED FROM gen/lib.bc. DO NOT MODIFY. ***
>
> #if 1
> extern const char *bc_lib_name;
>
> extern const char bc_lib[];
>
> const char *bc_lib_name =3D "gen/lib.bc";
>
> const char bc_lib[] =3D
> "scale=3D20\n"
> -----------------------------------------------------------------
>
> This file is generated by this rule in usr.bin/gh-bc/Makefile:
>
> lib.c: lib.bc
> cd ${BCDIR} && sh gen/strgen.sh gen/lib.bc=20
> ${.OBJDIR}/lib.c bc_lib bc_lib_name 1 1
>
> By a script that assigns parameters to variables:
>
> input=3D"$1"
> output=3D"$2"
> name=3D"$3"
> label=3D"$4"
> define=3D"$5"
> remove_tabs=3D"$6"
>
> And label=3D"bc_lib_name" is used to generate lib.c as included
> above (passed as 4th parameter).
>
> I'm rebuilding a clean world, now, but I'd be surprised if it failed
> after succeeding before readying the commit ...
A clean build (sort of) did fix it: rm the appropriate subdir actually.
--
Cheers,
Cy Schubert <Cy.Schubert@cschubert.com>
FreeBSD UNIX: <cy@FreeBSD.org> Web: https://FreeBSD.org
NTP: <cy@nwtime.org> Web: https://nwtime.org
The need of the many outweighs the greed of the few.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202011262247.0AQMlrE5071306>