Date: Fri, 19 Apr 2002 09:26:40 -0700 From: "David O'Brien" <obrien@FreeBSD.org> To: Ruslan Ermilov <ru@FreeBSD.org> Cc: ports@FreeBSD.org Subject: Re: cvs commit: src/share/mk bsd.port.mk Message-ID: <20020419092640.A28065@dragon.nuxi.com> In-Reply-To: <20020419112417.GA86103@sunbay.com>; from ru@FreeBSD.org on Fri, Apr 19, 2002 at 02:24:17PM %2B0300 References: <200204190740.g3J7ea347781@freefall.freebsd.org> <20020419010057.A4986@dragon.nuxi.com> <20020419082123.GJ53150@sunbay.com> <20020419021641.A6998@dragon.nuxi.com> <20020419112417.GA86103@sunbay.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, Apr 19, 2002 at 02:24:17PM +0300, Ruslan Ermilov wrote:
> Yes, there's nothing wrong if ports/Mk/bsd.port.mk includes <bsd.own.mk>.
> But Bill Fenner suggested that I put this into src/share/mk/bsd.port.mk
> so that version in ports/Mk can be kept FreeBSD-version independent and
> currently we only _need_ to include bsd.own.mk for HEAD.
We already have a lot of version dependent bits in ports/Mk/bsd.port.mk:
.if ${OSVERSION} >= 400014
.if !exists(/usr/lib/libcrypto.so)
# defaults to 4.x for -CURRENT; and 3.3.6 for all other branches
.if ${OSVERSION} > 500025
XFREE86_VERSION?= 4
.if defined(USE_GCC) && ${USE_GCC} == 2.95 && ${OSVERSION} < 400012
CC= gcc295
CXX= g++295
.if ${OSVERSION} >= 400014
BUILD_DEPENDS+= bison:${PORTSDIR}/devel/bison
.if ${OSVERSION} >= 500030
PERL_VERSION?= 5.6.1
.if ${OSVERSION} < 500016
PTHREAD_CFLAGS= -D_THREAD_SAFE
PTHREAD_LIBS= "-pthread"
I could go on. The .include of bsd.own.mk cannot be wrapped like this?
Do we move all this to share/mk/bsd.port.mk?
> That sounds reasonable at a glance, but wait! How it is supposed to work
> if ports/Mk/bsd.port.mk still depends on bsd.own.mk from src/share/mk?
I guess you are right. Presumable this wasn't seen as too bad as
typically bsd.own.mk is a very slow changing file.
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-ports" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20020419092640.A28065>