Date: Thu, 02 Aug 2001 15:57:04 -0700 From: Dima Dorfman <dima@unixfreak.org> To: Maxim Sobolev <sobomax@FreeBSD.org> Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org, sheldonh@freebsd.org Subject: Re: cvs commit: src/lib Makefile src/usr.bin Makefile src/usr.sbin Makefile Message-ID: <20010802225709.3F6F93E28@bazooka.unixfreak.org> In-Reply-To: <200108021547.f72Fl4151085@freefall.freebsd.org>; from sobomax@FreeBSD.org on "Thu, 2 Aug 2001 08:47:03 -0700 (PDT)"
next in thread | previous in thread | raw e-mail | index | archive | help
Maxim Sobolev <sobomax@FreeBSD.org> writes: > sobomax 2001/08/02 08:47:03 PDT > > Modified files: > lib Makefile > usr.bin Makefile > usr.sbin Makefile > Log: > Fix a cryptoless world by disconnecting libmp from the build when there is no > crypto bits installed and/or NOCRYPTO/NO_OPENSSL is defined. This unfortunately > meants that usr.bin/chkey, usr.bin/newkey and usr.sbin/keyserv have also to > be disconnected. I don't see why that's so unfortunate. Those programs should probably be considered to be `crypto' anyway since they deal with SecureRPC. Either way, this is being relatively actively (meaning some people have suggested something but not enough time has passed so that someone can say a consensus has been reached) discussed on -current, so I think this commit was premature. > IMO it is merely a workaround, the proper solution is to move libmp to > src/crypto where it belongs src/crypto is akin to src/contrib for crypto software; that's not where it belongs. Perhaps you mean src/secure? > and use libgmp for the cryptoless builds instead. libgmp should go away. As is being discussed on -current, everything that uses libmp uses it for crypto, so this seems like a non-issue. Sheldon Hearn wrote: > On Thu, 02 Aug 2001 08:47:03 MST, Maxim Sobolev wrote: > > > Log: > > Fix a cryptoless world by disconnecting libmp from the build when > > there is no crypto bits installed and/or NOCRYPTO/NO_OPENSSL > > is defined. This unfortunately meants that usr.bin/chkey, > > usr.bin/newkey and usr.sbin/keyserv have also to be disconnected. > > This is another one of those situations where someone has what seems to > be a good idea and rushes it into the tree. How long did you expect me to wait, and why didn't you or anybody else say anything when I proposed this on -arch two weeks ago, and -audit one week ago? This was *not* "rushed into the tree" by any means! > Can't we just acknowledge that trying to get rid of libgmp wasn't such a > hot idea for the here and now and revert that change? I still don't see what's wrong with it. No, the mp interface isn't that great, but we can't fix that. If you think it's not "a hot idea", at the very least please tell me why you didn't say anything during the last two weeks. Although I still won't mind to hearing a good reason for your allegation. To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20010802225709.3F6F93E28>