Date: Thu, 14 Jul 2005 15:50:27 GMT From: Paul Schmehl <pauls@utdallas.edu> To: freebsd-ports-bugs@FreeBSD.org Subject: Re: ports/77690: new port submission - security/sguil-server Message-ID: <200507141550.j6EFoRWO028011@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
The following reply was made to PR ports/77690; it has been noted by GNATS.
From: Paul Schmehl <pauls@utdallas.edu>
To: Sergey Matveychuk <sem@FreeBSD.org>, bug-followup@FreeBSD.org
Cc:
Subject: Re: ports/77690: new port submission - security/sguil-server
Date: Thu, 14 Jul 2005 10:43:12 -0500
--On Thursday, July 14, 2005 10:49:10 +0400 Sergey Matveychuk
<sem@FreeBSD.org> wrote:
> There is a few flows in the port.
> 1) Use MASTER_SITE_SUBDIR instead of addition you did in MASTER_SITES.
> 2) You can ommit ${LOCALBASE}/bin in RUN_DEPENDS macro.
> 3) Wrong logic with WITHOUT_X11 and WITH_MYSQL variables you use.
> The first: WITH_ and WITHOUT_ variables is for user options, you should
> never set them in Makefile.
>
> Second: instead of
> RUN_DEPENDS+=
> ${LOCALBASE}/lib/mysql/libmysqlclient.so:${PORTSDIR}/databases/mysql41-cl
> ient
> you should use USE_MYSQL macro which do all magic.
>
> Anyway a construction like that is bad looking:
> WITHOUT_X11= yes
> .if defined(WITHOUT_X11)
> ...
>
> 4) Don't hard code PREFIX=/usr/local in pkg-install instead of change it
> on PREFIX=%%PREFIX%%, move the file in files/pkg-install.in and add next
> lines in Makefile:
> PKGINSTALL=${WRKDIR}/pkg-install
> SUB_FILES=pkg-install
> 5) Don't use a random UID/GID. Select them from reserved numbers that you
> can in The Porters Handbook and ask a committer (me?) to register them
> there (you should give full lines like other in The Porters Handbook).
> And create user and group with these UID/GID.
> 6) Most bad thing. $Id$ tags should never been in patches. CVS will
> change them after commit and patches will not be applied.
>
Do I need to correct all these errors? Or do you correct them? (And
thanks for the corrections, btw. I'm very new at port maintaining.)
> BTW, tclX is broken and I can't check the port install.
>
Yes, I'm aware of that. I've contacted the port maintainer.
Paul Schmehl (pauls@utdallas.edu)
Adjunct Information Security Officer
University of Texas at Dallas
AVIEN Founding Member
http://www.utdallas.edu/ir/security/
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200507141550.j6EFoRWO028011>