Date: Thu, 6 Mar 2003 20:58:24 +0200 From: Ruslan Ermilov <ru@FreeBSD.org> To: "David O'Brien" <obrien@FreeBSD.org> Cc: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/usr.bin/less Makefile lesspipe.sh Message-ID: <20030306185824.GE78034@sunbay.com> In-Reply-To: <20030306181137.GB40027@dragon.nuxi.com> References: <200303060435.h264Zmkk039395@repoman.freebsd.org> <20030306154915.GE55489@sunbay.com> <20030306181137.GB40027@dragon.nuxi.com>
next in thread | previous in thread | raw e-mail | index | archive | help
--a1QUDc0q7S3U7/Jg Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Mar 06, 2003 at 10:11:37AM -0800, David O'Brien wrote: > On Thu, Mar 06, 2003 at 05:49:15PM +0200, Ruslan Ermilov wrote: > > On Wed, Mar 05, 2003 at 08:35:48PM -0800, David E. O'Brien wrote: > > > obrien 2003/03/05 20:35:48 PST > > >=20 > > > FreeBSD src repository > > >=20 > > > Modified files: > > > usr.bin/less Makefile=20 > > > Added files: > > > usr.bin/less lesspipe.sh=20 > > > Log: > > > Add an embellished lesspipe.sh as described in the man page. > > > P.S. it is stupid I have to define both SCRIPTS and SCRIPTSNAME. > > > =20 > > > Revision Changes Path > > > 1.8 +2 -0 src/usr.bin/less/Makefile > > > 1.1 +13 -0 src/usr.bin/less/lesspipe.sh (new) > > >=20 > > It is. > >=20 > > The usual practice is to strip extensions when installing scripts. > > Here, I'd suggest that you follow this practice too, and install > > this script as "lesspipe". >=20 > I realize that, and the answer is "no". I am following the documented > name in the man page. >=20 The "documented" name is an example only, it is not the default -- one still needs to set the LESSOPEN environment variable. The example script from the manpage can't even handle the `-' as the first character in the name. How do you expect people to know that we provide lesspipe.sh and they should set to LESSOPEN=3D/usr/bin/lesspipe.sh to explore it? The answer is to document this (hint: this can easily be done by compile-time adding the FreeBSD-specific section to the otherwise stock vendor file), where you can document the fact that FreeBSD provides /usr/bin/lesspipe (without .sh) suitable for LESSOPEN. In any case, it's not _stupid_, as the default behavior of SCRIPTSNAME of stripping extensions fits 99% of cases, and it was designed bearing this in mind. Cheers, --=20 Ruslan Ermilov Sysadmin and DBA, ru@sunbay.com Sunbay Software AG, ru@FreeBSD.org FreeBSD committer, +380.652.512.251 Simferopol, Ukraine http://www.FreeBSD.org The Power To Serve http://www.oracle.com Enabling The Information Age --a1QUDc0q7S3U7/Jg Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.1 (FreeBSD) iD8DBQE+Z5pQUkv4P6juNwoRAvaCAJ916ADFPXoTbGb7E3tsfPvgRpRXbACdHufM hXhdjwcCjfQXUPjJK7EFzyA= =EKz5 -----END PGP SIGNATURE----- --a1QUDc0q7S3U7/Jg-- To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20030306185824.GE78034>