Date: Fri, 11 Apr 2014 22:07:19 +0000 From: "Bjoern A. Zeeb" <bzeeb-lists@lists.zabbadoz.net> To: "Andrey V. Elsukov" <ae@FreeBSD.org> Cc: src-committers@freebsd.org, svn-src-user@freebsd.org Subject: Re: svn commit: r264358 - user/ae/inet6/sys/netinet6 Message-ID: <DC9E12F6-6C6A-4FDD-A1B0-A60B178FEC2F@lists.zabbadoz.net> In-Reply-To: <201404112148.s3BLmgC8064206@svn.freebsd.org> References: <201404112148.s3BLmgC8064206@svn.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 11 Apr 2014, at 21:48 , Andrey V. Elsukov <ae@FreeBSD.org> wrote: > Author: ae > Date: Fri Apr 11 21:48:41 2014 > New Revision: 264358 > URL: http://svnweb.freebsd.org/changeset/base/264358 >=20 > Log: > Application can use a global address belonging to the interface other > than the outgoing. >=20 > Found and tested by: bind9 Yeah right and then BCP38 catches is on the router and drops the packet. This change just sounds wrong. Maybe the application should be improved = instead. > Modified: > user/ae/inet6/sys/netinet6/in6_src.c >=20 > Modified: user/ae/inet6/sys/netinet6/in6_src.c > = =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D > --- user/ae/inet6/sys/netinet6/in6_src.c Fri Apr 11 21:14:10 2014 = (r264357) > +++ user/ae/inet6/sys/netinet6/in6_src.c Fri Apr 11 21:48:41 2014 = (r264358) > @@ -411,9 +411,9 @@ check_addrs(const struct sockaddr_in6 *s > struct in6_ifaddr *ia; >=20 > /* > - * Check that source address is available on the interface. > + * Check that source address is available. > */ > - ia =3D in6ifa_ifpwithaddr(ifp, &src->sin6_addr); > + ia =3D in6ifa_ifwithaddr(&src->sin6_addr, src->sin6_scope_id); > if (ia =3D=3D NULL || ( > ia->ia6_flags & (IN6_IFF_ANYCAST | IN6_IFF_NOTREADY))) { > if (ia !=3D NULL) >=20 =97=20 Bjoern A. Zeeb ????????? ??? ??????? ??????: '??? ??? ???? ?????? ??????? ?? ?? ??????? ??????? ??? ????? ????? ???? ?????? ?? ????? ????', ????????? ?????????, "??? ????? ?? ?????", ?.???
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?DC9E12F6-6C6A-4FDD-A1B0-A60B178FEC2F>