Date: Mon, 28 May 2001 10:01:58 +0300 From: Peter Pentchev <roam@orbitel.bg> To: Mike Heffner <mheffner@cowpie.acm.vt.edu> Cc: freebsd-audit@freebsd.org Subject: Re: cmp(1) patch Message-ID: <20010528100158.C8450@ringworld.oblivion.bg> In-Reply-To: <20010528100017.B8450@ringworld.oblivion.bg>; from roam@orbitel.bg on Mon, May 28, 2001 at 10:00:17AM %2B0300 References: <20010527232926.A85869@cowpie.acm.vt.edu> <20010528100017.B8450@ringworld.oblivion.bg>
next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, May 28, 2001 at 10:00:17AM +0300, Peter Pentchev wrote: > On Sun, May 27, 2001 at 11:29:27PM -0400, Mike Heffner wrote: > > BDECFLAGS cleanup, respect -s flag in one place, return instead of > > exit() at end of main. Please review. > > > > Index: cmp.c > > =================================================================== > > RCS file: /home/ncvs/src/usr.bin/cmp/cmp.c,v > > retrieving revision 1.9 > > diff -u -r1.9 cmp.c > > --- cmp.c 2000/07/25 13:01:34 1.9 > > +++ cmp.c 2001/05/26 21:57:56 > > @@ -58,6 +58,7 @@ > > > > int lflag, sflag, xflag, zflag; > > > > +int main __P((int, char *[])); > > static void usage __P((void)); > > Does gcc with BDECFLAGS really complain for a missing prototype on main()? > I thought gcc was smart enough (it is, at least on -stable).. Eh, nevermind. Of course you're modifying programs with old K&R function declarations, where the declarations themselves are not prototypes. Sorry. G'luck, Peter -- When you are not looking at it, this sentence is in Spanish. To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-audit" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20010528100158.C8450>