Date: Fri, 25 Apr 2003 02:11:54 -0700 (PDT) From: Nate Lawson <nate@root.org> To: cvs-all@FreeBSD.org, cvs-src@FreeBSD.org, src-committers@FreeBSD.org Subject: Re: cvs commit: src/sys/dev/fxp if_fxp.c if_fxpvar.h Message-ID: <Pine.BSF.4.21.0304250204280.64445-100000@root.org> In-Reply-To: <20030425090201.5740737B48C@hub.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, 25 Apr 2003, Nate Lawson wrote: > njl 2003/04/25 02:01:54 PDT > > Modified files: > sys/dev/fxp if_fxp.c if_fxpvar.h > Log: > Make fxp(4) INTR_MPSAFE (but do not enable MPSAFE just yet): As the comment in the code says, MPSAFE is not enabled because ifnet is not locked yet. I was informed of this by hsu@. However, the driver was very stable for me (no crashes or increased packet loss) so I am committing this code so others can test it. If you do enable MPSAFE, be aware of potential data loss or crashes. For developers, note that the locking in the code path only protects the various fxp routines (fxp_start, fxp_intr, fxp_tick, ...) and is not intended to serialize access to ANY external structures. This is how it should be. Please do not copy the exact approach taken here for a little while until ifnet locking is finished as there may need to be some changes made to this model. -Nate
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?Pine.BSF.4.21.0304250204280.64445-100000>