Date: Thu, 16 Nov 2017 22:12:26 +0100 From: Hans Petter Selasky <hps@selasky.org> To: Bryan Drewery <bdrewery@FreeBSD.org>, src-committers@freebsd.org, svn-src-projects@freebsd.org Subject: Re: svn commit: r325894 - projects/bsd_rdma_4_9 Message-ID: <97fb917d-8495-6ccf-9772-6b05da10e5f1@selasky.org> In-Reply-To: <a46a9d84-eb10-0fcf-9312-983dad229a4c@FreeBSD.org> References: <201711161513.vAGFDThx060235@repo.freebsd.org> <a46a9d84-eb10-0fcf-9312-983dad229a4c@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 11/16/17 17:56, Bryan Drewery wrote: > On 11/16/2017 7:13 AM, Hans Petter Selasky wrote: >> Author: hselasky >> Date: Thu Nov 16 15:13:28 2017 >> New Revision: 325894 >> URL: https://svnweb.freebsd.org/changeset/base/325894 >> >> Log: >> Update list of hardcoded OFED build order dependencies for >> the buildworld target. >> >> Sponsored by: Mellanox Technologies >> >> Modified: >> projects/bsd_rdma_4_9/Makefile.inc1 >> Hi, >> > > This isn't right, you don't need to include any 'include' directories in > here as 'make includes' is ran before 'make libraries'. I tried leaving the include directory out and it failed. > > You don't need libthr either as it is in prebuild_libs which is built > before all of this. OK. I'll update it tomorrow. > > I suspect the actual change needed is far smaller than this. > Thank you for your review. --HPS
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?97fb917d-8495-6ccf-9772-6b05da10e5f1>