Date: Thu, 15 Dec 2016 07:01:32 +0000 From: Colin Percival <cperciva@tarsnap.com> To: Dimitry Andric <dim@FreeBSD.org>, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r310086 - head/sys/dev/xen/blkfront Message-ID: <010001590149368d-51a8dd17-ce30-4c65-a117-087cf47dc8a5-000000@email.amazonses.com> In-Reply-To: <201612141928.uBEJSJor074348@repo.freebsd.org> References: <201612141928.uBEJSJor074348@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 12/14/16 11:28, Dimitry Andric wrote: > Log: > In xbd_connect(), use correct scanf conversion specifiers for the > feature_barrier and feature_flush variables. Otherwise, adjacent > variables on the stack, such as sector_size, may be overwritten, with > disastrous results. Thanks! Did you happen to notice what stack variable (if any?) was being overwritten under clang 3.8.0? Just wondering if there might be some undiscovered issue lurking in FreeBSD releases which will cause other less obvious problems. -- Colin Percival Security Officer Emeritus, FreeBSD | The power to serve Founder, Tarsnap | www.tarsnap.com | Online backups for the truly paranoid
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?010001590149368d-51a8dd17-ce30-4c65-a117-087cf47dc8a5-000000>