Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 25 Jul 2014 09:44:56 -0400
From:      Julio Merino <jmmv@freebsd.org>
To:        Baptiste Daroussin <bapt@freebsd.org>
Cc:        "svn-src-head@freebsd.org" <svn-src-head@freebsd.org>, "svn-src-all@freebsd.org" <svn-src-all@freebsd.org>, "src-committers@freebsd.org" <src-committers@freebsd.org>
Subject:   Re: svn commit: r268811 - in head: contrib/byacc contrib/byacc/package contrib/byacc/package/debian contrib/byacc/package/pkgsrc contrib/byacc/test contrib/byacc/test/btyacc contrib/byacc/test/yacc usr...
Message-ID:  <CAFY7cWCJvVE-JTG4vST60uLOXKEjTU1ZAZr_YdzDrR_V1wKbtw@mail.gmail.com>
In-Reply-To: <201407172222.s6HMMcC6034903@svn.freebsd.org>
References:  <201407172222.s6HMMcC6034903@svn.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, Jul 17, 2014 at 6:22 PM, Baptiste Daroussin <bapt@freebsd.org> wrote:
> Author: bapt
> Date: Thu Jul 17 22:22:38 2014
> New Revision: 268811
> URL: http://svnweb.freebsd.org/changeset/base/268811
>
> Log:
>   Update to byacc 20140715 (only concerns regression tests being fixed)
>   Directly use regression test from upstream
>
>   PR:           191020
>   Submitted by: gcooper (yaneurabeya@gmail.com)
>
> Added:
>   head/usr.bin/yacc/tests/yacc_tests.sh   (contents, props changed)

The tests handling in this change is severely broken.

The following files were removed from /usr/tests:

-/usr/tests/usr.bin/yacc/Kyuafile
-/usr/tests/usr.bin/yacc/ftp.y
-/usr/tests/usr.bin/yacc/legacy_test
-/usr/tests/usr.bin/yacc/regress.00.out
-/usr/tests/usr.bin/yacc/regress.01.out
-/usr/tests/usr.bin/yacc/regress.02.out
-/usr/tests/usr.bin/yacc/regress.03.out
-/usr/tests/usr.bin/yacc/regress.04.out
-/usr/tests/usr.bin/yacc/regress.05.out
-/usr/tests/usr.bin/yacc/regress.06.out
-/usr/tests/usr.bin/yacc/regress.07.out
-/usr/tests/usr.bin/yacc/regress.08.out
-/usr/tests/usr.bin/yacc/regress.09.out
-/usr/tests/usr.bin/yacc/regress.10.out
-/usr/tests/usr.bin/yacc/regress.11.out
-/usr/tests/usr.bin/yacc/regress.12.out
-/usr/tests/usr.bin/yacc/regress.13.out
-/usr/tests/usr.bin/yacc/regress.14.out
-/usr/tests/usr.bin/yacc/regress.sh
-/usr/tests/usr.bin/yacc/undefined.y

... yet no entries exist in OptionalObsoleteFiles.mk for them.

Also, note that the Kyuafile is now gone so these tests are useless
where they are as they cannot be executed.

Please fix.



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAFY7cWCJvVE-JTG4vST60uLOXKEjTU1ZAZr_YdzDrR_V1wKbtw>