Date: Fri, 20 Apr 2007 13:51:34 +0000 (UTC) From: Andre Oppermann <andre@FreeBSD.org> To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org Subject: cvs commit: src/sys/netinet tcp_input.c tcp_syncache.c Message-ID: <200704201351.l3KDpZfk013832@repoman.freebsd.org>
next in thread | raw e-mail | index | archive | help
andre 2007-04-20 13:51:34 UTC
FreeBSD src repository
Modified files:
sys/netinet tcp_input.c tcp_syncache.c
Log:
Simplifly syncache_expand() and clarify its semantics. Zero is returned
when the ACK is invalid and doesn't belong to any registered connection,
either in syncache or through SYN cookies. True but a NULL struct socket
is returned when the 3WHS completed but the socket could not be created
due to insufficient resources or limits reached.
For both cases an RST is sent back in tcp_input().
A logic error leading to a panic is fixed where syncache_expand() would
free the mbuf on socket allocation failure but tcp_input() later supplies
it to tcp_dropwithreset() to issue a RST to the peer.
Reported by: kris (the panic)
Revision Changes Path
1.337 +8 -8 src/sys/netinet/tcp_input.c
1.113 +4 -17 src/sys/netinet/tcp_syncache.c
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200704201351.l3KDpZfk013832>