Date: Mon, 9 Apr 2007 03:07:03 +0200 From: Pawel Jakub Dawidek <pjd@FreeBSD.org> To: Max Laier <max@love2party.net> Cc: freebsd-fs@freebsd.org, Dag-Erling Sm?rgrav <des@des.no>, freebsd-current@freebsd.org Subject: Re: ZFS committed to the FreeBSD base. Message-ID: <20070409010703.GA74547@garage.freebsd.pl> In-Reply-To: <20070408185312.GY63916@garage.freebsd.pl> References: <20070406025700.GB98545@garage.freebsd.pl> <86k5wo55s0.fsf@dwp.des.no> <200704081910.42852.max@love2party.net> <20070408185312.GY63916@garage.freebsd.pl>
next in thread | previous in thread | raw e-mail | index | archive | help
--82I3+IH0IqGh5yIs
Content-Type: text/plain; charset=iso-8859-2
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
On Sun, Apr 08, 2007 at 08:53:12PM +0200, Pawel Jakub Dawidek wrote:
> fzap_upgrade() changes type from 'zap_micro' to 'zap_fat' and union is
> used for this (see
> sys/contrib/opensolaris/uts/common/fs/zfs/sys/zap_impl.h), that's why we
> see this trash:
>=20
> zap_num_entries_mtx =3D {lock_object =3D {lo_name =3D 0x70000 <Address 0x=
70000 out of bounds>,
> lo_type =3D 0x0, lo_flags =3D 2155822976, lo_witness_data =3D {lod_list =
=3D {stqe_next =3D 0x0},
> lod_witness =3D 0x0}}, sx_lock =3D 1, sx_recurse =3D 0},
>=20
> I already use kmem_zalloc() (note _z_) for zap allocation in
> zap_micro.c, so Max is right, that we have to clear this structure here.
>=20
> I'm quite tired of tracking such problems, because our mechanism for
> detecting already initialized locks is too simple (based on one bit), so
> I'd prefer to improve it, or just add bzero() to mutex_init().
I just committed a fix. Now I do 13 bits check for already initialized
locks detection instead of standard 1 bit check. Could you repeat your
test?
--=20
Pawel Jakub Dawidek http://www.wheel.pl
pjd@FreeBSD.org http://www.FreeBSD.org
FreeBSD committer Am I Evil? Yes, I Am!
--82I3+IH0IqGh5yIs
Content-Type: application/pgp-signature
Content-Disposition: inline
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (FreeBSD)
iD8DBQFGGZG3ForvXbEpPzQRAkuzAJ9B0hzoFOn1hi/obdoxJDmh7vKZlwCg796x
J97euQ4Nk4LEW9Qv1Z/mQsw=
=qgao
-----END PGP SIGNATURE-----
--82I3+IH0IqGh5yIs--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20070409010703.GA74547>