Date: Tue, 17 Oct 2006 08:16:19 GMT From: Roman Divacky <rdivacky@FreeBSD.org> To: Perforce Change Reviews <perforce@FreeBSD.org> Subject: PERFORCE change 108021 for review Message-ID: <200610170816.k9H8GJfe023389@repoman.freebsd.org>
next in thread | raw e-mail | index | archive | help
http://perforce.freebsd.org/chv.cgi?CH=108021 Change 108021 by rdivacky@rdivacky_witten on 2006/10/17 08:15:38 Remove locking of the proc. Holding of proctree_lock is sufficient. Pointed out by: jhb Affected files ... .. //depot/projects/linuxolator/src/sys/compat/linux/linux_emul.c#12 edit Differences ... ==== //depot/projects/linuxolator/src/sys/compat/linux/linux_emul.c#12 (text+ko) ==== @@ -212,12 +212,8 @@ q = LIST_FIRST(&p->p_children); for (; q != NULL; q = nq) { nq = LIST_NEXT(q, p_sibling); - PROC_LOCK(q); - if (q->p_flag & P_WEXIT) { - PROC_UNLOCK(q); + if (q->p_flag & P_WEXIT) continue; - } - PROC_UNLOCK(q); if (__predict_false(q->p_sysent != &elf_linux_sysvec)) continue; em = em_find(q, EMUL_UNLOCKED);
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200610170816.k9H8GJfe023389>