Date: Wed, 26 Jul 2006 00:40:01 +0400
From: Yar Tikhiy <yar@comp.chem.msu.su>
To: Doug Barton <dougb@FreeBSD.org>
Cc: freebsd-rc@FreeBSD.org
Subject: Re: Generalising ${required_*}
Message-ID: <20060725204001.GC73669@comp.chem.msu.su>
In-Reply-To: <44C2687A.3030102@FreeBSD.org>
References: <20060722111449.GE10321@comp.chem.msu.su> <44C2687A.3030102@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sat, Jul 22, 2006 at 11:03:38AM -0700, Doug Barton wrote:
> Yar Tikhiy wrote:
> > Hi all,
> >
> > As of now, the ${required_*} variables work only in rc.d scripts
> > using the default start method. I've found that making ${required_*}
> > work in scripts that override the default start method can help us
> > to reduce code duplication in /etc/rc.d. In particular, I'd like
> > to introduce ${required_modules} because quite a few scripts have
> > to have a prestart method just to load a kernel module.
> >
> > Do you think such change would make sense? Thanks.
> >
> > Its prototype can be found in my P4 tree:
> > //depot/user/yar/hack/etc/...
> > (also available via www at http://perforce.freebsd.org)
>
> For those of us who are p4 impaired, can you give us a URL to view the
> changes you're proposing?
Thank you for requesting this! It encouraged me to test my changes
at last and prepare a good old patch :-)
http://people.freebsd.org/~yar/required_modules.patch
Its top part converts quite a few rc.d scripts to using $required_modules
if possible or load_kld() otherwise in place of raw kldload. The
respective changes to rc.subr and rc.subr.8 appear at the bottom
of the patch.
--
Yar
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20060725204001.GC73669>