Date: Wed, 23 Oct 2019 10:42:19 +0200 From: Niclas Zeising <zeising+freebsd@daemonic.se> To: Mark Johnston <markj@freebsd.org> Cc: Neel Chauhan <neel@neelc.org>, Mateusz Guzik <mjguzik@gmail.com>, Evilham <contact@evilham.com>, FreeBSD Current <freebsd-current@freebsd.org>, owner-freebsd-current@freebsd.org Subject: Re: DRM-current-kmod is still a problem at r353339 Message-ID: <29e29759-18bc-6747-ab11-e15eea4ac738@daemonic.se> In-Reply-To: <96d8f37a-179b-ecad-62d1-5a097d30c0ed@daemonic.se> References: <CAGudoHE755ig7KGuzq8uNY01K2Jcf-MKBjCp8kbpJAoiHdbQMA@mail.gmail.com> <99c89ca0-462c-f4c7-fa07-6f61e9d39d66@acm.org> <f2e7c4b4c236ee694f277d78479cb6ee@neelc.org> <CAGudoHGwmp=vNwOy2W22rjx_mQj1nkbdYzuLfayM7O0vn4keeA@mail.gmail.com> <bb951f83-6a50-48ce-8efa-b8fa92a9840e@yggdrasil.evilham.com> <CAGudoHGoikyZudFSxYjypF8EL24BPxBTPQjAnCKTe%2Bvg3DJiWQ@mail.gmail.com> <bb4f31fcb7f06059f1d9fe391b119661@neelc.org> <3bb2e410-51dd-bc3f-7660-41a4683551b3@daemonic.se> <20191017195347.GB6447@raichu> <53ff1ac5-c7e8-1b6c-bd43-481eaef61120@daemonic.se> <20191017210510.GC6447@raichu> <96d8f37a-179b-ecad-62d1-5a097d30c0ed@daemonic.se>
next in thread | previous in thread | raw e-mail | index | archive | help
On 2019-10-21 10:13, Niclas Zeising wrote: > On 2019-10-17 23:05, Mark Johnston wrote: >> On Thu, Oct 17, 2019 at 10:31:12PM +0200, Niclas Zeising wrote: >>> On 2019-10-17 21:53, markj@freebsd.org wrote: >>>> On Thu, Oct 17, 2019 at 03:03:51PM +0200, Niclas Zeising wrote: >>>>> On 2019-10-16 18:57, Neel Chauhan wrote: >>>>>> While drm-current-kmod worked for a little while, it broke with=20 >>>>>> r353645. >>>>>> >>>>>> https://i.imgur.com/Q5nYZf2.jpg >>>>>> >>>>>> I'm using the same HP Spectre that I used earlier (where it worked= =20 >>>>>> and >>>>>> where it panicked). >>>>>> >>>>> >>>>> That commit looks unrelated, it touches the wbwd and superio driver= s, >>>>> nothing else.=C2=A0 Any chance you can bisect exactly which revisio= n that >>>>> caused the new issues? >>>> >>>> I believe it was the recent work on the vm page busy state, r353539 >>>> specifically.=C2=A0 This patch should fix it; we don't yet have a >>>> __FreeBSD_version number bump on which to gate the patch. >>>> >>>> diff --git a/linuxkpi/gplv2/src/linux_page.c=20 >>>> b/linuxkpi/gplv2/src/linux_page.c >>>> index e2b85c45c..060ae85ed 100644 >>>> --- a/linuxkpi/gplv2/src/linux_page.c >>>> +++ b/linuxkpi/gplv2/src/linux_page.c >>>> @@ -239,7 +239,7 @@ retry: >>>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0 page =3D vm_page_lookup(devobj, i); >>>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0 if (page =3D=3D NULL) >>>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 continue; >>>> -=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 = if (vm_page_sleep_if_busy(page, "linuxkpi")) >>>> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 = if (!vm_page_busy_acquire(page, VM_ALLOC_WAITFAIL)) >>>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 goto retry; >>>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0 cdev_pager_free_page(devobj, page); >>>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 } >>> >>> Hi! >>> Hopefully someone can confirm that this patch to drm-current-kmod or >>> drm-devel-kmod fixes the issue.=C2=A0 I won't be able to work on this= before >>> the weekend at the earliest, I'm afraid. >>> Mark, is it possible to get a belated version bump for this fix, and >>> what changed to require it? >> >> I committed the bump and verified the patch on amdgpu.=C2=A0 Here are = some >> PRs for the drivers: >> >> https://github.com/FreeBSDDesktop/kms-drm/pull/180 >> https://github.com/FreeBSDDesktop/kms-drm/pull/181 >=20 > Hi! > I'm working on getting this into the versions that are in ports.=C2=A0 = For=20 > drm-current-kmod it's fairly simple, but for drm-devel-kmod there are=20 > unrelated changes which I need to check if they are ready to go in or=20 > not, so it will take some more time. >=20 > Looking at the mail list thread, there seems to be a patch needed for=20 > base as well, has this been committed? drm-devel-kmod and drm-current-kmod has been updated with the above fix. If there are further issues, please let us know. Regards --=20 Niclas
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?29e29759-18bc-6747-ab11-e15eea4ac738>