Date: Tue, 21 Apr 2015 17:46:56 +0200 From: Piotr Robert Konopelko <piotr.konopelko@moosefs.com> To: Ben Woods <woodsb02@gmail.com>, Fernando =?ISO-8859-1?Q?Apestegu=EDa?= <fernando.apesteguia@gmail.com>, FreeBSD Ports <ports@freebsd.org> Cc: Jakub Kruszona-Zawadzki <jakub.kruszona@gemius.com>, MooseFS FreeBSD Ports <freebsd@moosefs.com> Subject: Re: MooseFS Ports for versions 2.0 and 3.0 Message-ID: <11260707.dYzYoTeF1T@hp> In-Reply-To: <33D11311-008D-43F5-A341-316CD4D831EA@gemius.com> References: <2694094.4JmStLgM3m@hp> <CAOc73CBrQ-4X2Hhc19CEOcY8K2f06X7EFLGxpuo2V39ZooGaHA@mail.gmail.com> <33D11311-008D-43F5-A341-316CD4D831EA@gemius.com>
next in thread | previous in thread | raw e-mail | index | archive | help
Hello, I've submitted the upgraded ports and obsoleted prior attachments. Please review them. https://bugs.freebsd.org/bugzilla/buglist.cgi?quicksearch=moosefs[1] In the meantime MooseFS has been upgraded, so I posted ports to the 2.0.63-1 version. Thanks in advance :) -- Best regards, Piotr Robert Konopelko *MooseFS Technical Support Engineer* | moosefs.com[2] (...) 3. It's nice for ports for share parts of their configuration, but I don't think it should be called "bsd.port.moosefs.mk[3]" (this implies it is part of the port build scripts). A good example of what you could do is devel/libtool. It has a Makefile which includes Makefile.common. The devel/libltdl port also includes "${.CURDIR}/../libtool/Makefile.common". The name was used by original port creator. I've change it to Makefile.common. 4. @dirrm is now deprecated in pkg-plist. Suggest it is probably easier to build this with "make install && make makeplist > pkg-plist". Note that you should check the plist looks correct, and also delete the top warning line from the generated file. Yes. I've changed @dirrm[try] to @dir or removed them. I've also added '@owner mfs' and '@group mfs' and compared each list with the result of "make makeplist". 5. The pkg-descr file should be updated to include a better description of the package, and link to the website. Yes. I've made much better descriptions. 6. Before submitting a port, check that it passes the normal checks by installing the ports- mgmt/portlint program, and running "portlint -AC" in the port directory. portlint -AC gives something like this: [root@fbsdmule /usr/ports/sysutils/moosefs-master]# portlint -AC WARN: Makefile: PORTVERSION/DISTVERSION is set externally to this port's Makefile, but this port is not configured as a slave port. WARN: Makefile: MAINTAINER is set externally to this port's Makefile, but this port is not configured as a slave port. 0 fatal errors and 2 warnings found. I hope that I can leave it - I've checked other random ports and such warning are very usual. 7. If you have access to a poudriere installation, you should submit the "poudriere testport" logs showing that this port will build successfully. Yes we have. We use poudriere to make packages, so all our ports are always checked by poudriere. Myself or other ports contributors/committers can help with this if you do not have access to a poudriere installation, but please make sure you have at least tested the build on FreeBSD with a "make install". Much of this is covered in the porter's handbook. It's a good read if you haven't already seen it. You can find it here: https://www.freebsd.org/doc/en/books/porters-handbook/book.html[4] Note that if you re-submit patches to each bug report, be sure to tick the option that it obsolete's the previous patch. Ok. We'll send those ports again. Good luck! :) Thanks again for your comments. It was very helpful. -- Regards,Jakub Kruszona-Zawadzki- - - - - - - - - - - - - - - -Segmentation fault (core dumped)Phone: +48 602 212 039 -------- [1] https://bugs.freebsd.org/bugzilla/buglist.cgi?quicksearch=moosefs [2] http://moosefs.com [3] http://bsd.port.moosefs.mk/ [4] https://www.freebsd.org/doc/en/books/porters-handbook/book.html
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?11260707.dYzYoTeF1T>