Date: Sat, 12 Jan 2008 23:55:25 +0300 (MSK) From: Maxim Konovalov <maxim@macomnet.ru> To: David Schultz <das@freebsd.org> Cc: cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/usr.sbin/iostat iostat.c Message-ID: <20080112235350.C10888@mp2.macomnet.net> In-Reply-To: <20080112205254.GB3090@VARK.MIT.EDU> References: <200801122037.m0CKb6CS009262@repoman.freebsd.org> <20080112205254.GB3090@VARK.MIT.EDU>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sat, 12 Jan 2008, 15:52-0500, David Schultz wrote: > On Sat, Jan 12, 2008, Maxim Konovalov wrote: > > - asprintf(&devname, "%s%d", > > + if (asprintf(&devname, "%s%d", > > cur.dinfo->devices[di].device_name, > > - cur.dinfo->devices[di].unit_number); > > + cur.dinfo->devices[di].unit_number) == 1) > > + errx(1, "asprintf() failed (out of memory?)"); > > err(1, "asprintf") will produce a more meaningful error message, > by the way. Also, I think you wanted to compare the return value > of asprintf to -1 instead of 1. > err(1, "asprintf") was my first version, yes. But I failed to find in the man page it sets errno. Thanks for the review, I'll fix the typo shortly. -- Maxim Konovalov
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20080112235350.C10888>