Date: Mon, 12 Jul 1999 16:30:02 -0700 (PDT) From: Bob Bishop <rb@gid.co.uk> To: freebsd-bugs@FreeBSD.org Subject: Re: bin/10985: make .NOTPARALLEL special target is broken[PATCH] Message-ID: <199907122330.QAA84497@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
The following reply was made to PR bin/10985; it has been noted by GNATS. From: Bob Bishop <rb@gid.co.uk> To: hoek@FreeBSD.org Cc: freebsd-gnats-submit@FreeBSD.org Subject: Re: bin/10985: make .NOTPARALLEL special target is broken[PATCH] Date: Tue, 13 Jul 1999 00:08:43 +0000 Hi, >> >> How-To-Repeat >> >> `make -jn -dj' with and without .NOTPARALLEL: in the >> Makefile > >Could you give an example Makefile where .NOTPARRALLEL doesn't work? >The .NOTPARRALLEL seems to work for me. Include the specific arguments >given to make(1), please. OK, it's not quite straightforward. Unshar the following... # This is a shell archive. Save it in a file, remove anything before # this line, and then unpack it by entering "sh file". Note, it may # create directories; files and directories will be owned by you and # have default permissions. # # This archive contains: # # subdir # makefile # subdir/makefile # subdir/thing # echo c - subdir mkdir -p subdir > /dev/null 2>&1 echo x - makefile sed 's/^X//' >makefile << 'END-of-makefile' X.NOTPARALLEL: X Xall: FRC X cd subdir; make X XFRC: END-of-makefile echo x - subdir/makefile sed 's/^X//' >subdir/makefile << 'END-of-subdir/makefile' Xall: thing1 thing2 X Xthing1: FRC X cp thing thing1 X Xthing2: FRC X cp thing thing2 X XFRC: END-of-subdir/makefile echo x - subdir/thing sed 's/^X//' >subdir/thing << 'END-of-subdir/thing' XAny old thing END-of-subdir/thing exit # end of shar ...and try 'make -j2 -dj' at the top, with and without the .NOTPARALLEL. The problem is that the .NOTPARALLEL message isn't correctly passed to the submake. Try adding a .NOTPARALLEL in subdir/makefile, this will work. The patch in the PR fixes the problem, but I haven't tested it with remote (as opposed to SMP) parallel builds (I have no idea whether remote builds work anyway). -- Bob Bishop (0118) 977 4017 international code +44 118 rb@gid.co.uk fax (0118) 989 4254 between 0800 and 1800 UK To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-bugs" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199907122330.QAA84497>