Date: Wed, 31 May 2006 07:19:25 -0700 (PDT) From: Matthew Jacob <mj@feral.com> To: Don Lewis <truckman@FreeBSD.org> Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/cam cam_xpt.c src/sys/cam/scsi scsi_all.h Message-ID: <20060531071852.Q72653@ns1.feral.com> In-Reply-To: <200605310930.k4V9UpWa001360@gw.catspoiler.org> References: <200605310930.k4V9UpWa001360@gw.catspoiler.org>
next in thread | previous in thread | raw e-mail | index | archive | help
*blink*? It did break things? My apologies- I could have sworn that I'd done a LINT check. Sorry- I'll get right on this. On Wed, 31 May 2006, Don Lewis wrote: > On 30 May, Matt Jacob wrote: >> mjacob 2006-05-30 22:44:00 UTC >> >> FreeBSD src repository >> >> Modified files: >> sys/cam cam_xpt.c >> sys/cam/scsi scsi_all.h >> Log: >> Handle some of the inquiry flags that have come into >> usage as of SPC2r20. Specifically, handle the BQueue >> flag which will indicate that a device supports the >> Basic Queueing model (no Head of Queue or Ordered tags). >> When this flag is set, SID_CmdQueue is clear. This has >> causes FreeBSD to assume that the device did not support >> tagged operations. > > This commit broke compilation of the ahb driver, which appears to be > trying to get the number of ecbs from the spc2_flags member of > scsi_inquiry_data, which it tries to access under the old member name, > reserved[1]. Not that I care all that much because I don't have any ahb > hardware, but this driver is included in the GENERIC kernel. > >
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20060531071852.Q72653>