Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 21 Feb 2017 03:31:57 +0000
From:      bugzilla-noreply@freebsd.org
To:        freebsd-bugs@FreeBSD.org
Subject:   [Bug 217260] [kbdmux] fails to compile with LINT on ^/stable/10
Message-ID:  <bug-217260-8-c9s1sX6dvk@https.bugs.freebsd.org/bugzilla/>
In-Reply-To: <bug-217260-8@https.bugs.freebsd.org/bugzilla/>
References:  <bug-217260-8@https.bugs.freebsd.org/bugzilla/>

next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D217260

Li-Wen Hsu <lwhsu@FreeBSD.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |bdrewery@FreeBSD.org

--- Comment #1 from Li-Wen Hsu <lwhsu@FreeBSD.org> ---
We had discussed this earlier, I cut off a section and paste here:

> /workspace/src/sys/modules/kbdmux/../../dev/kbdmux/kbdmux.c:411:26: error=
: use of undeclared identifier 'key_map'; did you mean 'keymap'?
>                 keymap =3D malloc(sizeof(key_map), M_KBDMUX, M_NOWAIT);
>                                        ^~~~~~~
>                                        keymap

The error here is what happens when the header, kbdmuxmap.h, is empty.
Note the error was not "no such file", but rather missing structures.  I
hit this issue when I added options KBDMUX_DFLT_KEYMAP to my kernel
config but did not set a value for it.

I see this was added by Ed in r297685.

I'm guessing somehow the LINT build is not specifying a default value
for KBDMUX_DFLT_KEYMAP...

When I go into sys/amd64/conf and run 'make LINT' I do get
KBDMUX_DFLT_KEYMAP=3Dit.iso in the LINT file.

> kbdmuxmap.h:
>         kbdcontrol -P ${S:S/sys$/share/}/vt/keymaps -P ${S:S/sys$/share/}=
/syscons/keymaps -L ${KBDMUX_DFLT_KEYMAP} | sed -e 's/^static keymap_t.* =
=3D /static keymap_t key_map =3D /' -e 's/^static accentmap_t.* =3D /static=
 accentmap_t accent_map =3D /' > kbdmuxmap.h

Perhaps this is failing and not creating a proper header file.

> I have some new discovery, originally I built -CURRENT LINT on 10.3-R,
> it failed no matter what parallelism or not.  Then I change environment to
> 11.0-BETA1 and it builds successfully, with or without parallelism:

Does the 10.0 kbdcontrol support the -P/-L flags to generate this
header?  It may just need to be added as a build tool.

--=20
You are receiving this mail because:
You are the assignee for the bug.=



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-217260-8-c9s1sX6dvk>