Date: Sat, 24 Aug 2002 20:22:24 +0200 From: Wilko Bulte <wkb@freebie.xs4all.nl> To: John Polstra <jdp@FreeBSD.ORG> Cc: cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG Subject: Re: cvs commit: src/lib/libc/net rcmd.c Message-ID: <20020824202224.A21671@freebie.xs4all.nl> In-Reply-To: <200208241737.g7OHbgNV063820@freefall.freebsd.org>; from jdp@FreeBSD.ORG on Sat, Aug 24, 2002 at 10:37:42AM -0700 References: <200208241737.g7OHbgNV063820@freefall.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sat, Aug 24, 2002 at 10:37:42AM -0700, John Polstra wrote: > jdp 2002/08/24 10:37:42 PDT > > Modified files: > lib/libc/net rcmd.c > Log: > Fix a bug in __ivaliduser_sa() which caused some rsh/rlogin attempts > to fail needlessly if a reverse DNS lookup of the IP address didn't > come up with a hostname. As a comment in the code clearly stated, > the "damn hostname" was looked up only for the purpose of netgroup > matching. But if that lookup failed, the function bailed out > immediately even though in many cases netgroup matching would not > be used. > > This change marks the hostname as unknown but continues. Where > netgroup matching is performed, an unknown hostname is handled > conservatively. I.e., for "+@netgroup" (accept) entries an unknown > hostname never matches, and for "-@netgroup" (reject) entries an > unknown hostname always matches. > > In the lines affected (only), I also fixed a few bogus casts. There > are others, and in fact this entire file would be a good candidate > for a cleanup sweep. > > Reviewed by: imp (wearing his flourescent yellow Security Team cap) Can we have a photograph of that fluorescent etc please? -- | / o / /_ _ wilko@FreeBSD.org |/|/ / / /( (_) Bulte Arnhem, the Netherlands To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20020824202224.A21671>