Skip site navigation (1)Skip section navigation (2)
Date:      Sun, 8 Aug 2021 09:15:52 +0200
From:      Marcin Wojtas <mw@semihalf.com>
To:        Ian Lepore <ian@freebsd.org>
Cc:        Marcin Wojtas <mw@freebsd.org>, src-committers <src-committers@freebsd.org>, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org
Subject:   Re: git: dfcaa2c18bf9 - main - enetc_mdio: Support building the driver as a loadable module.
Message-ID:  <CAPv3WKfgUohSqNAncOijSNSy3aM_8LKJ4dkzoFNSqGPp%2B1CLag@mail.gmail.com>
In-Reply-To: <b9649ea3b840f027fbd59271cf83523fb515cfca.camel@freebsd.org>
References:  <202108031008.173A84BG096694@gitrepo.freebsd.org> <b9649ea3b840f027fbd59271cf83523fb515cfca.camel@freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
Hi Ian,

wt., 3 sie 2021 o 18:31 Ian Lepore <ian@freebsd.org> napisa=C5=82(a):
>
> On Tue, 2021-08-03 at 10:08 +0000, Marcin Wojtas wrote:
> > The branch main has been updated by mw:
> >
> > URL:
> > https://cgit.FreeBSD.org/src/commit/?id=3Ddfcaa2c18bf9c69b94d531364f891=
3b23f19505f
> >
> > commit dfcaa2c18bf9c69b94d531364f8913b23f19505f
> > Author:     Kornel Duleba <mindal@semihalf.com>
> > AuthorDate: 2021-07-28 11:38:53 +0000
> > Commit:     Marcin Wojtas <mw@FreeBSD.org>
> > CommitDate: 2021-08-03 10:07:49 +0000
> >
> >     enetc_mdio: Support building the driver as a loadable module.
> >
> > [...]
> > diff --git a/sys/modules/enetc_mdio/Makefile
> > b/sys/modules/enetc_mdio/Makefile
> > new file mode 100644
> > index 000000000000..f448fc526705
> > --- /dev/null
> > +++ b/sys/modules/enetc_mdio/Makefile
> > @@ -0,0 +1,8 @@
> > +#$FreeBSD$
> > +
> > +.PATH: ${SRCTOP}/sys/dev/enetc
> > +
> > +KMOD   =3D enetc_mdio
> > +SRCS   =3D enetc_mdio_pci.c enetc_mdio.c
> > +
> > +.include <bsd.kmod.mk>
>
> A module makefile must list all the header files it uses which are
> generated at build time from interface definitions (.m files) in its
> SRCS list.  For this driver, I think that means ifdi_if.h and
> miibus_if.h.
>
> -- Ian
>

Agreed. Part of it was already fixed by manu, I'm about to add
remaining dependencies.

Thanks,
Marcin



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAPv3WKfgUohSqNAncOijSNSy3aM_8LKJ4dkzoFNSqGPp%2B1CLag>