Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 15 May 2013 09:32:33 +0800
From:      Martin Wilke <miwi@bsdhash.org>
To:        Alexey Dokuchaev <danfe@FreeBSD.org>
Cc:        svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, Raphael Kubo da Costa <rakuco@FreeBSD.org>, ports-committers@freebsd.org
Subject:   Re: svn commit: r318182 - in head/ports-mgmt: kports kports-qt4
Message-ID:  <183E9696-A472-4C12-90D8-B7E27741A7A4@bsdhash.org>
In-Reply-To: <20130515012023.GB28077@FreeBSD.org>
References:  <201305141809.r4EI9MaD031903@svn.freebsd.org> <20130515012023.GB28077@FreeBSD.org>

next in thread | previous in thread | raw e-mail | index | archive | help

On May 15, 2013, at 9:20 AM, Alexey Dokuchaev <danfe@FreeBSD.org> wrote:

> On Tue, May 14, 2013 at 06:09:22PM +0000, Raphael Kubo da Costa wrote:
>> New Revision: 318182
>> URL: http://svnweb.freebsd.org/changeset/ports/318182
>> 
>> COMMENT=	Qt4-Version of your favorite frontend to the Ports
>> [...]
>> COMMENT=	KDE3-Version of your favorite frontend to the Ports
> 
> Hm,
> 
> 1) Why "version" is capitalized and prepended with hyphen?
> 2) COMMENT should not talk to a user (no "your" part) and assume its
>   preferences and likes ("favorite" part)
> 3) "Ports" can probably be expanded to "Ports Collection" or something

Another style discussion?

> 
> ./danfe
> 

+-----------------oOO--(_)--OOo-------------------------+
With best Regards,
       Martin Wilke (miwi_(at)_FreeBSD.org)

Mess with the Best, Die like the Rest




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?183E9696-A472-4C12-90D8-B7E27741A7A4>