Date: Wed, 25 Aug 2004 20:49:09 +0300 From: Ruslan Ermilov <ru@FreeBSD.org> To: "David O'Brien" <obrien@FreeBSD.org>, current@FreeBSD.org Subject: Re: BETA1 5.3 make world DESTDIR failure Message-ID: <20040825174908.GA97530@ip.net.ua> In-Reply-To: <20040825173707.GH53710@dragon.nuxi.com> References: <1093402508.488.8.camel@home> <20040825134842.M553@beagle.kn.op.dlr.de> <20040825134722.GD5872@ip.net.ua> <20040825173707.GH53710@dragon.nuxi.com>
next in thread | previous in thread | raw e-mail | index | archive | help
--envbJBWh7q8WU6mo Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Aug 25, 2004 at 10:37:07AM -0700, David O'Brien wrote: > On Wed, Aug 25, 2004 at 04:47:22PM +0300, Ruslan Ermilov wrote: > > as IMAKEENV (from Makefile.inc1) doesn't utilize DESTDIR. I think I > > know how to fix "make world DESTDIR=3D/foo" to make it work again -- we > > need to convert all DESTDIR uses in Makefile.inc1 to be command-line > > variables. I'm currently testing this patch, and it looks promising: >=20 > Please also test 'make world' without DESTDIR in /etc/make.conf, but with > 1. "HISTORICAL_MAKE_WORLD=3Dyes" in /etc/make.conf > 2. env HISTORICAL_MAKE_WORLD=3Dyes make world > before committing. >=20 That's pointless for this change. If HISTORICAL_MAKE_WORLD is defined and DESTDIR is not (irrelevant where), "make world" is just equivalent to "make buildworld" followed by "make installworld". Clearly, "make buildworld" without DESTDIR works with and without this change. Cheers, --=20 Ruslan Ermilov ru@FreeBSD.org FreeBSD committer --envbJBWh7q8WU6mo Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.5 (FreeBSD) iD8DBQFBLNEUqRfpzJluFF4RAq4+AJ4lSwE6gqtruUiVrBtbf/AaZXkQFACfUrna xI2xioTAtAPIqgFNBEMZT8E= =lQXW -----END PGP SIGNATURE----- --envbJBWh7q8WU6mo--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20040825174908.GA97530>