Date: Sun, 5 Oct 2014 23:40:07 +0200 From: Mateusz Guzik <mjguzik@gmail.com> To: "Bjoern A. Zeeb" <bz@FreeBSD.org> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, Konstantin Belousov <kib@freebsd.org>, Mateusz Guzik <mjg@FreeBSD.org> Subject: Re: svn commit: r272567 - in head/sys: kern sys Message-ID: <20141005214006.GF9262@dft-labs.eu> In-Reply-To: <20141005204716.GE9262@dft-labs.eu> References: <201410051940.s95JeUg7069798@svn.freebsd.org> <2438AED3-AC72-4099-ACD6-E2642B4A866D@FreeBSD.org> <20141005204716.GE9262@dft-labs.eu>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sun, Oct 05, 2014 at 10:47:16PM +0200, Mateusz Guzik wrote: > On Sun, Oct 05, 2014 at 08:26:59PM +0000, Bjoern A. Zeeb wrote: > > > > On 05 Oct 2014, at 19:40 , Mateusz Guzik <mjg@FreeBSD.org> wrote: > > > > > Author: mjg > > > Date: Sun Oct 5 19:40:29 2014 > > > New Revision: 272567 > > > URL: https://svnweb.freebsd.org/changeset/base/272567 > > > > > > Log: > > > filedesc: fix up breakage introduced in 272505 > > > > > > Include sequence counter supports incoditionally [1]. This fixes reprted build > > > problems with e.g. nvidia driver due to missing opt_capsicum.h. > > > > > > Replace fishy looking sizeof with offsetof. Make fde_seq the last member in > > > order to simplify calculations. > > > > Seing this on an incremental build now for > > > > bmake: stopped in /scratch/tmp/bz/head.svn/lib/libkvm > > > > /storage/head/obj//mips.mipsel/scratch/tmp/bz/head.svn/tmp/usr/include/sys/filedesc.h:57: error: expected specifier-qualifier-list before 'seq_t' > > > > I’ll see if this persists with a full build but I assume it will. > > > > I cannot reproduce it, tried with mips + QEMU config. > > One crap thing is that typedef uint32_t seq_t is placed before includes. > > Does it help if you move it after systm.h? > > Was the failure present prior to this patch? > Sigh, sorry, totally misread what you wrote. Fixed in r272574. -- Mateusz Guzik <mjguzik gmail.com>
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20141005214006.GF9262>