Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 6 Dec 2014 00:18:54 +0000 (UTC)
From:      Xin LI <delphij@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-vendor@freebsd.org
Subject:   svn commit: r275542 - vendor-sys/illumos/dist/uts/common/fs/zfs
Message-ID:  <201412060018.sB60IsV6030020@svn.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: delphij
Date: Sat Dec  6 00:18:53 2014
New Revision: 275542
URL: https://svnweb.freebsd.org/changeset/base/275542

Log:
  5311 traverse_dnode may report success when it should not
  Reviewed by: Matthew Ahrens <mahrens@delphix.com>
  Reviewed by: Andriy Gapon <avg@FreeBSD.org>
  Reviewed by: Will Andrews <willa@spectralogic.com>
  Approved by: Dan McDonald <danmcd@omniti.com>
  Author: Justin T. Gibbs <justing@spectralogic.com>
  
  illumos/illumos-gate@2a89c2c59b7c2beb2373c14368cbe7e32af6ffc1

Modified:
  vendor-sys/illumos/dist/uts/common/fs/zfs/dmu_traverse.c

Modified: vendor-sys/illumos/dist/uts/common/fs/zfs/dmu_traverse.c
==============================================================================
--- vendor-sys/illumos/dist/uts/common/fs/zfs/dmu_traverse.c	Sat Dec  6 00:17:25 2014	(r275541)
+++ vendor-sys/illumos/dist/uts/common/fs/zfs/dmu_traverse.c	Sat Dec  6 00:18:53 2014	(r275542)
@@ -429,7 +429,7 @@ traverse_dnode(traverse_data_t *td, cons
 			break;
 	}
 
-	if (dnp->dn_flags & DNODE_FLAG_SPILL_BLKPTR) {
+	if (err == 0 && dnp->dn_flags & DNODE_FLAG_SPILL_BLKPTR) {
 		SET_BOOKMARK(&czb, objset, object, 0, DMU_SPILL_BLKID);
 		err = traverse_visitbp(td, dnp, &dnp->dn_spill, &czb);
 	}



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201412060018.sB60IsV6030020>