Date: Sun, 11 Mar 2001 15:28:04 -0800 (PST) From: John Baldwin <jhb@FreeBSD.org> To: Dag-Erling Smorgrav <des@ofug.org> Cc: cvs-all@FreeBSD.org, cvs-committers@FreeBSD.org, Jake Burkholder <jburkholder0829@home.com> Subject: Re: cvs commit: src/sys/alpha/include mutex.h src/sys/i386/inclu Message-ID: <XFMail.010311152804.jhb@FreeBSD.org> In-Reply-To: <xzpu250xlsi.fsf@flood.ping.uio.no>
next in thread | previous in thread | raw e-mail | index | archive | help
On 11-Mar-01 Dag-Erling Smorgrav wrote: > Jake Burkholder <jburkholder0829@home.com> writes: >> > 1.106 +5 -1 src/sys/kern/kern_fork.c > > This one's wrong. It sets p2->p_spinlocks to 1 unconditionally, but if > the kernel was compiled with WITNESS_SKIPSPIN, p_spinlocks is not > decremented when the sched_lock is released, so mtx_legal2block() > always fails and the kernel panics during boot. See the panic and > backtrace I posted to -CURRENT. Ugh, ok. I know how to fix this, and will do so in the new witness code I'm about halfway through. Just don't use skipspin for the time being. I would only turn it on if spinlocks give you problems (which they shouldn't). > DES > -- > Dag-Erling Smorgrav - des@ofug.org -- John Baldwin <jhb@FreeBSD.org> -- http://www.FreeBSD.org/~jhb/ PGP Key: http://www.baldwin.cx/~john/pgpkey.asc "Power Users Use the Power to Serve!" - http://www.FreeBSD.org/ To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?XFMail.010311152804.jhb>