Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 2 Aug 2003 19:14:17 -0400
From:      Garance A Drosihn <drosih@rpi.edu>
To:        Riccardo Torrini <riccardo@torrini.org>, freebsd-current@FreeBSD.ORG
Subject:   Re: newsyslog problems with -C
Message-ID:  <p052106b5bb51f576bd66@[128.113.24.47]>
In-Reply-To: <20030802003845.GE73426@trudy.torrini.home>
References:  <20030802000332.GD73426@trudy.torrini.home> <20030802003845.GE73426@trudy.torrini.home>

next in thread | previous in thread | raw e-mail | index | archive | help
At 2:38 AM +0200 8/2/03, Riccardo Torrini wrote:
>
>Looking into sources I found two close(fd).
>Here is the patch:
>
>-----8<-----[ patch ]-----8<-----
># diff -u newsyslog.c.orig newsyslog.c
>--- newsyslog.c.orig    Sun May 25 18:46:13 2003
>+++ newsyslog.c Sat Aug  2 02:28:50 2003
>@@ -1764,7 +1764,6 @@
>			failed = fchown(fd, ent->uid, ent->gid);
>			if (failed)
>				err(1, "can't fchown temp file %s", tempfile);
>-				(void) close(fd);
>		}
>	}
>-----8<-----[ patch ]-----8<-----

I committed this in -current.  I'll MFC it into -stable in a
few days.  Thanks!

-- 
Garance Alistair Drosehn            =   gad@gilead.netel.rpi.edu
Senior Systems Programmer           or  gad@freebsd.org
Rensselaer Polytechnic Institute    or  drosih@rpi.edu



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?p052106b5bb51f576bd66>