Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 14 Apr 2021 18:10:15 +0300
From:      Andriy Gapon <avg@FreeBSD.org>
To:        Mark Johnston <markj@freebsd.org>
Cc:        freebsd-stable List <stable@freebsd.org>, FreeBSD Current <current@freebsd.org>
Subject:   Re: stable/13, vm page counts do not add up
Message-ID:  <9b1aa260-f54a-dc7a-bf19-1d83a49a01ac@FreeBSD.org>
In-Reply-To: <YHbu8ApV7KfXEU%2By@nuc>
References:  <0606571f-fec0-c7ad-98e8-a0b8554918e2@FreeBSD.org> <YG4OAVa0ohh4illU@nuc> <f509bf54-e283-eb29-2db2-1457dae7bc13@FreeBSD.org> <YG4ckaRbub6kEFO8@nuc> <dd0a979f-8a50-ab28-9701-0a8cddc9471b@FreeBSD.org> <YHYKsl/sNBNYZUDC@nuc> <23d370fa-41db-a89b-03fd-e45deb874aed@FreeBSD.org> <YHbu8ApV7KfXEU%2By@nuc>

next in thread | previous in thread | raw e-mail | index | archive | help
On 14/04/2021 16:32, Mark Johnston wrote:
> On Wed, Apr 14, 2021 at 02:21:44PM +0300, Andriy Gapon wrote:
>> On 14/04/2021 00:18, Mark Johnston wrote:
>>> fbt::vm_page_unwire:entry
>>> /args[0]->oflags & 0x4/
>>> {
>>> 	@unwire[stack()] = count();
>>> }
>>
>> Unrelated report, dtrace complains about this probe on my stable/13 system:
>>       failed to resolve translated type for args[0]
>>
>> And I do not have any idea why...
> 
> There was a regression, see PR 253440.  I think you have the fix
> already, but perhaps not.  Could you show output from
> "dtrace -lv -n fbt::vm_page_unwire:entry"?

dtrace -lv -n fbt::vm_page_unwire:entry
    ID   PROVIDER            MODULE                          FUNCTION NAME
54323        fbt            kernel                    vm_page_unwire entry

         Probe Description Attributes
                 Identifier Names: Private
                 Data Semantics:   Private
                 Dependency Class: Unknown

         Argument Attributes
                 Identifier Names: Private
                 Data Semantics:   Private
                 Dependency Class: ISA

         Argument Types
                 args[0]: (unknown)
                 args[1]: (unknown)

It seems that I should have the fix, but somehow I still have the problem.
I've been doing NO_CLEAN builds for a long while, so maybe some stale file 
didn't get re-created...

It looks that dt_lex.c under /usr/obj is rather dated.

... I've removed that file and rebuilt libdtrace and everything is okay now.
Thank you.

>>   From ctfdump:
>>     [27290] FUNC (vm_page_unwire) returns: 38 args: (1463, 3)
>>
>>     <1463> TYPEDEF vm_page_t refers to 778
>>     <778> POINTER (anon) refers to 3575
>>     <3575> STRUCT vm_page (104 bytes)
>>           plinks type=3563 off=0
>>           listq type=3558 off=128
>>           object type=3564 off=256
>>           pindex type=3565 off=320
>>           phys_addr type=42 off=384
>>           md type=3571 off=448
>>           ref_count type=31 off=640
>>           busy_lock type=31 off=672
>>           a type=3573 off=704
>>           order type=3 off=736
>>           pool type=3 off=744
>>           flags type=3 off=752
>>           oflags type=3 off=760
>>           psind type=2167 off=768
>>           segind type=2167 off=776
>>           valid type=3574 off=784
>>           dirty type=3574 off=792
>>
>> -- 
>> Andriy Gapon


-- 
Andriy Gapon



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?9b1aa260-f54a-dc7a-bf19-1d83a49a01ac>