Date: Sat, 11 Aug 2001 17:02:57 -0400 From: Mike Barcroft <mike@FreeBSD.org> To: Matt Dillon <dillon@earth.backplane.com> Cc: Josef Karthauser <joe@tao.org.uk>, Eivind Eklund <eivind@FreeBSD.org>, cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: CVS patch implements update -T (was Re: Remote CVS/Template) Message-ID: <20010811170257.B23231@coffee.q9media.com> In-Reply-To: <200108111945.f7BJjIo19532@earth.backplane.com>; from dillon@earth.backplane.com on Sat, Aug 11, 2001 at 12:45:18PM -0700 References: <3B4F1FCD.7F2D4842@FreeBSD.org> <20010713120140Q.jkh@osd.bsdi.com> <20010713211017.A57434@heechee.tobez.org> <20010713123241X.jkh@osd.bsdi.com> <200107132214.f6DMET571067@earth.backplane.com> <20010715143503.A10888@FreeBSD.org> <20010810133132.G624@tao.org.uk> <200108111945.f7BJjIo19532@earth.backplane.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sat, Aug 11, 2001 at 12:45:18PM -0700, Matt Dillon wrote: > Ok, here is a patch. I think this is fairly reasonable. It handles > the case where the developer normally operates from a local CVS tree > (e.g. for cvs update), and may or may not use an override when comitting. > Index: entries.c > =================================================================== > RCS file: /home/ncvs/src/contrib/cvs/src/entries.c,v > retrieving revision 1.1.1.5.2.1 > diff -u -r1.1.1.5.2.1 entries.c > --- entries.c 2000/10/31 09:37:52 1.1.1.5.2.1 > +++ entries.c 2001/08/11 19:37:56 [...] > + asprintf(&tmp, "%s/%s", dir, CVSADM_TEMPLATE); > + asprintf(&root_template, "%s/CVSROOT/rcstemplate", root); [...] Is there a reason why you aren't checking the result of asprintf(3) for memory allocation errors? I believe your other patch suffers from a similar problem with strdup(3). Other than that, the changes look good. BTW, great article on DaemonNews this month. Best regards, Mike Barcroft To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20010811170257.B23231>