Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 27 Jun 2013 12:13:51 -0700
From:      Garrett Cooper <yaneurabeya@gmail.com>
To:        Glen Barber <gjb@FreeBSD.org>
Cc:        svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org
Subject:   Re: svn commit: r252101 - head/release
Message-ID:  <1D76B2CE-575C-4456-BC3A-7249D030970A@gmail.com>
In-Reply-To: <20130622225106.GK1888@glenbarber.us>
References:  <201306222212.r5MMCO8t091190@svn.freebsd.org> <1397DF51-1DCC-47BC-931A-5D26C94A0811@gmail.com> <20130622225106.GK1888@glenbarber.us>

next in thread | previous in thread | raw e-mail | index | archive | help
On Jun 22, 2013, at 3:51 PM, Glen Barber wrote:

> On Sat, Jun 22, 2013 at 03:39:41PM -0700, Garrett Cooper wrote:
>> On Jun 22, 2013, at 3:12 PM, Glen Barber wrote:
>>=20
>>> Author: gjb
>>> Date: Sat Jun 22 22:12:24 2013
>>> New Revision: 252101
>>> URL: http://svnweb.freebsd.org/changeset/base/252101
>>>=20
>>> Log:
>>> If MAKE_CONF and/or SRC_CONF are set and not character devices,
>>> copy to chroot to use with release build.
>>>=20
>>> Submitted by:	Garrett Cooper (original version)
>>> Approved by:	kib (mentor)
>>> MFC after:	1 week
>>>=20
>>> Modified:
>>> head/release/release.sh
>>=20
>> Technically copying /dev/null to a file creates a 0 byte file.
>> That's why I used cp in the patch I submitted over email.
>> Thanks!
>=20
> Right.  But did you read the script?
>=20
> Both __MAKE_CONF and SRCCONF are set to the path of the local files.

	Oh, interesting=85 I see what you did there instead of what I =
proposed; I copied __MAKE_CONF to /etc/make.conf and SRCCONF to =
/etc/src.conf for symmetry with the base system, but your method works =
more than mine did (I forgot that you were passing those vars in the =
chroot environment). Should the files be installed to /etc/ in the =
system default locations ?
Thanks!
-Garrett=



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1D76B2CE-575C-4456-BC3A-7249D030970A>