Date: Sun, 16 Sep 2001 07:50:17 +1000 (EST) From: Bruce Evans <bde@zeta.org.au> To: "David E. O'Brien" <obrien@FreeBSD.org> Cc: <cvs-committers@FreeBSD.org>, <cvs-all@FreeBSD.org> Subject: Re: cvs commit: src/sys/sys cdefs.h Message-ID: <20010916073910.C30591-100000@delplex.bde.org> In-Reply-To: <200109152110.f8FLAPO61073@freefall.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sat, 15 Sep 2001, David E. O'Brien wrote: > obrien 2001/09/15 14:10:25 PDT > > Modified files: > sys/sys cdefs.h > Log: > Allow __FBSDID() to be used without ; > > Revision Changes Path > 1.39 +4 -4 src/sys/sys/cdefs.h I hope that this misfeature was intentionally left out. Using __FBSDID() without a ';' would break would utilities like indent(1) and gtags(1). It then looks like a function definition to indent(1) at least; this causes indent(1) to misindent everything following it. All the code that correctly uses __FBSDID() with a ';' is now uncompilable by C compilers since it has null declarations. The change also breaks __RCSID(). Please back this out. Bruce To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20010916073910.C30591-100000>