Date: Thu, 14 May 2020 08:19:01 +0000 From: bugzilla-noreply@freebsd.org To: ports-bugs@FreeBSD.org Subject: [Bug 241347] security/sssd: Update to 1.16.4 Message-ID: <bug-241347-7788-jMcC7P3VEq@https.bugs.freebsd.org/bugzilla/> In-Reply-To: <bug-241347-7788@https.bugs.freebsd.org/bugzilla/> References: <bug-241347-7788@https.bugs.freebsd.org/bugzilla/>
next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D241347 --- Comment #23 from the_mix_room@hotmail.com --- I played around a little with this yesterday. Having missed this entry I initially tired to recreate it myself.=20 The work generally looks good, and I only have some minor comments on all t= hree patches, I think they seem quite similar and would benefit from being merged into one.=20 * patch-src_external_pac__responder.m4 is renamed patch-src__external_pac__responder.m4, ( s/_/__/ which is correct - there w= as a _ missing previously) Inside the attachment 212864 there are changes to whi= ch versions are included, previously 1.17* was included, now it is 1.17 * HOST_NAME_MAX is replaced by _POSIX_HOST_NAME_MAX in the code, instead of previously being defined in Makefile.am. Perhaps it would be easier to use = an ifndef-block instead. I used sysconf(_SC_HOST_NAME_MAX) instead of the cons= tant _POSIX_HOST_NAME_MAX. On my machine they are the same value, but I do not t= hink there is guarantees for this.=20 * CONFIGURE_ARGS in Makefile have changed order, this makes it quite diffic= ult to follow what has been added or changed. * 1.16.4 has been replaced by 1.16.5 in the meantime. Other than that I will add myself to the list of people that would like to = test this when there is a suitable patch. --=20 You are receiving this mail because: You are the assignee for the bug.=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-241347-7788-jMcC7P3VEq>