Date: Fri, 7 Jun 2013 14:33:08 +0400 From: Gleb Smirnoff <glebius@FreeBSD.org> To: Mikolaj Golub <trociny@FreeBSD.org>, zec@FreeBSD.org, Nikos Vassiliadis <nvass@gmx.com> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r251490 - head/sys/net Message-ID: <20130607103307.GA1187@FreeBSD.org> In-Reply-To: <201306071027.r57ARpaF056606@svn.freebsd.org> References: <201306071027.r57ARpaF056606@svn.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, Jun 07, 2013 at 10:27:51AM +0000, Mikolaj Golub wrote: M> Author: trociny M> Date: Fri Jun 7 10:27:50 2013 M> New Revision: 251490 M> URL: http://svnweb.freebsd.org/changeset/base/251490 M> M> Log: M> Properly set curvnet context in lagg_port_setlladdr() task handler. M> M> Reported by: Nikos Vassiliadis <nvass gmx.com> M> Submitted by: zec M> Tested by: Nikos Vassiliadis <nvass gmx.com> M> MFC after: 1 week M> M> Modified: M> head/sys/net/if_lagg.c M> M> Modified: head/sys/net/if_lagg.c M> ============================================================================== M> --- head/sys/net/if_lagg.c Fri Jun 7 09:06:50 2013 (r251489) M> +++ head/sys/net/if_lagg.c Fri Jun 7 10:27:50 2013 (r251490) M> @@ -505,7 +505,9 @@ lagg_port_setlladdr(void *arg, int pendi M> ifp = llq->llq_ifp; M> M> /* Set the link layer address */ M> + CURVNET_SET(ifp->if_vnet); M> error = if_setlladdr(ifp, llq->llq_lladdr, ETHER_ADDR_LEN); M> + CURVNET_RESTORE(); M> if (error) M> printf("%s: setlladdr failed on %s\n", __func__, M> ifp->if_xname); IMHO, the entire task function should be embraced into VNET context. -- Totus tuus, Glebius.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20130607103307.GA1187>