Date: Fri, 24 Jun 2016 09:28:07 +0200 From: Mathieu Arnold <mat@FreeBSD.org> To: Adam Weinberger <adamw@adamw.org> Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r417374 - in head: Mk Mk/Uses lang/php55 lang/php56 lang/php70 www/redaxo Message-ID: <7E036E80F9D532528C3155FB@atuin.in.mat.cc> In-Reply-To: <307F483A-1ABE-4E02-A268-16F014D8DC44@adamw.org> References: <201606231319.u5NDJILd062527@repo.freebsd.org> <2400E414-B4B4-479C-BE0F-D804F1E0110A@adamw.org> <83BA65E7C58012B7AA8A7962@atuin.in.mat.cc> <307F483A-1ABE-4E02-A268-16F014D8DC44@adamw.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--==========F9985B992DBCB821BBA4========== Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Content-Disposition: inline +--On 23 juin 2016 16:37:36 -0600 Adam Weinberger <adamw@adamw.org> wrote: |> On 23 Jun, 2016, at 15:36, Mathieu Arnold <mat@FreeBSD.org> wrote: |> |> +--On 23 juin 2016 13:46:41 -0600 Adam Weinberger <adamw@adamw.org> |> wrote: |> |> On 23 Jun, 2016, at 7:19, Mathieu Arnold <mat@FreeBSD.org> wrote: |> |> |> |> Author: mat |> |> Date: Thu Jun 23 13:19:17 2016 |> |> New Revision: 417374 |> |> URL: https://svnweb.freebsd.org/changeset/ports/417374 |> |> |> |> Log: |> |> Move bsd.php.mk to Uses/php.mk |> |> |> |> PR: 210323 |> |> Submitted by: mat |> |> Exp-run by: antoine |> |> Sponsored by: Absolight |> |> Differential Revision: https://reviews.freebsd.org/D6867 |> | |> |> # If you are building PHP-based ports in poudriere(8) with ZTS |> |> # enabled, add WITH_MPM=event to /etc/make.conf to prevent build |> |> # failures. |> | |> | Does USES=php still have the above bug? If not, are there plans to make |> | ZTS detection work without assuming that everybody has apache |> | installed? |> |> I did not change a thing, I'm modernizing the framework, I'm changing how |> things are done, but not what the things being done do. |> |> (Also, I have absolutely no idea what ZTS is, or what the difference |> between the different MPM are.) | | ZTS is a threading model for PHP. For a long time, bsd.php.mk has made | the strange decision to use the output of 'httpd -V' (from apache) to | determine whether PHP was built with ZTS. It uses that to determine which | directory to put modules into. | | The problem with that bizarre method is that if you don't have apache | installed, it puts modules into the wrong directory, and then all further | builds fail. In order to build PHP ports in poudriere, you have to trick | the system by using that WITH_MPM=event line. | | There are a couple bugs open about it. 201193 and 207284 are both open | for it. php.mk should either put all PHP modules into one place (there's | really no point to making the module dir change), or figure out whether | PHP was built with ZTS by examining php.ini or the output of php-config. I'll have a look at it, I'm refactoring USES=php right now[1]. Though, I'm more inclined to do baby steps, and not change what's in it. The directory could easily be put in the php.conf file, it would solve all those problems, I think. 1: https://reviews.freebsd.org/D6936 -- Mathieu Arnold --==========F9985B992DBCB821BBA4========== Content-Type: application/pgp-signature Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQJ8BAEBCgBmBQJXbOEHXxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXQzQUI2OTc4OUQyRUQxMjEwNjQ0MEJBNUIz QTQ1MTZGMzUxODNDRTQ4AAoJEDpFFvNRg85I39IQAIfLCTDzX3XpduiJSNJ59KIL cYmV1g/QFkwCV17/J9mOljrwB358AtFkqkxf3c60QsAAyDbnbP0ryrwBZhEjtgZg o5aNhImmsbAQQXb+PgEg9NJSEdvuf4ggdKZZR5MinNivjGFBH2IKjRM60Hu02g2e 3SM5yWY99PTH8PWaU0ZMiAvLAgxMFMZc03jVkwfNQqUdyceFK4B/p28XzRePM+y5 /6jmDwUMzfNrjsnH0ZN7T1dHjwce88j6zfEpRfQ7hCOTx4vzlf7pdKS85Q9kRyeC ru493Qc3HhDMvqTpJ30DAYocpUWqF4/BxpuLBZW8iUtalTKjQacIxPITtdgtKvTp 1hxr81+z/Odpha/2T/S2fXfZv/OVw93Ylh498o9elsLARBUD6HUba5+ipjhOpCj/ He0zu6HOJ/gkK+pgNXPscBz4pf+7TcKDyMJSfdvTWGFhoeCaCF631XZFtcxkbqqq toC5vIzeoMN4AgKWKI0UDu+k+tcRMG9tNQxgLCFfjtj+SoeuZUt2WJWkUTi6LXLF 1NjUVIDX3AiFaXnCwc4cKg+/9ThEmakYTlvVVumUiRkb3j7XX0IPPLzXmoE1ahTg uKGcRfufd4e2MdPmcIgDE4E7O5NMNMusfnq5o4BImWX28OSnMj8L/ZB0YUxxqXvq qrv41RkMlkW2CwasPUGE =ZEFT -----END PGP SIGNATURE----- --==========F9985B992DBCB821BBA4==========--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?7E036E80F9D532528C3155FB>